Sign upLogin

YouTransfer/YouTransfer

View on GitHub
Star

Showing 61 of 61 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should try to retrieve the url using JQuery XHR and replace target with result (same id)', function(done) {

        var fixture = getFixture();
        new anchor(fixture);
Severity: Major
Found in src/js/components/anchor/anchor.test.js and 1 other location - About 1 day to fix
src/js/components/anchor/anchor.test.js on lines 64..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 282.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('should try to retrieve the url using JQuery XHR and replace target with result (different id)', function(done) {

        var fixture = getFixture();
        new anchor(fixture);
Severity: Major
Found in src/js/components/anchor/anchor.test.js and 1 other location - About 1 day to fix
src/js/components/anchor/anchor.test.js on lines 33..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 282.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function exports has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (function() {

    var self = {};
    self.settings = require('./settings');
    self.log = require('./logger')('youtransfer');
Severity: Minor
Found in lib/youtransfer.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 257 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (function() {

    var self = {};
    self.settings = require('./settings');
    self.log = require('./logger')('youtransfer');
Severity: Major
Found in lib/youtransfer.js - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should try to post to the url using JQuery XHR and replace target with result', function(done) {

        var fixture = getFixture();
        new form(fixture);
    Severity: Major
    Found in src/js/components/form/form.test.js and 1 other location - About 6 hrs to fix
    src/js/components/form/form.test.js on lines 51..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 164.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it('should try to post to the url using JQuery XHR and replace target with result (different id)', function(done) {

        var fixture = getFixture();
        new form(fixture);
    Severity: Major
    Found in src/js/components/form/form.test.js and 1 other location - About 6 hrs to fix
    src/js/components/form/form.test.js on lines 30..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 164.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if(req.headers.host) {
                var requestUrl = (req.socket.encrypted ? 'https://' : 'http://') + req.headers.host;
                var currentUrl = url.parse(requestUrl);
                var baseUrl = url.parse(settings.general.baseUrl);
                context.invalidHost = (currentUrl.host !== baseUrl.host);
    Severity: Major
    Found in lib/middleware.js and 1 other location - About 4 hrs to fix
    lib/middleware.js on lines 57..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if(req.headers.host) {
                var requestUrl = (req.socket.encrypted ? 'https://' : 'http://') + req.headers.host;
                var currentUrl = url.parse(requestUrl);
                var baseUrl = url.parse(settings.general.baseUrl);
                context.invalidHost = (currentUrl.host !== baseUrl.host);
    Severity: Major
    Found in lib/middleware.js and 1 other location - About 4 hrs to fix
    lib/middleware.js on lines 87..93

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function exports has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(req, res, next) {

    // Fixing missing parsed body object in Restify (for usage in Passport)
    req.body = req.params;
    Severity: Major
    Found in lib/middleware.js - About 4 hrs to fix

      Function Fileupload has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Fileupload(element) {
    var component = this;
    component.$element = $(element);
    component.$element.addClass(DROPZONE_CLASS);
      Severity: Major
      Found in src/js/components/fileupload/fileupload.js - About 3 hrs to fix

        Function exports has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function(req, res, next) {

    // Fixing missing parsed body object in Restify (for usage in Passport)
    req.body = req.params;
        Severity: Minor
        Found in lib/middleware.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File youtransfer.js has 275 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict';

// ------------------------------------------------------------------------------------------ Dependencies

require('date-utils');
        Severity: Minor
        Found in lib/youtransfer.js - About 2 hrs to fix

          Function archive has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          LocalFileStorage.prototype.archive = function(token, res, next) {
    try {
        var self = this;
        var basedir = this.localstoragepath;
        if(token) {
          Severity: Major
          Found in lib/localstorage.js - About 2 hrs to fix

            File routes.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            'use strict';

// ------------------------------------------------------------------------------------------ Dependencies

require('date-utils');
            Severity: Minor
            Found in lib/routes.js - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      youtransfer.settings.unlock(req.params.unlockCode, function(err) {
            req.errors.parse(err);
            if(req.errors.exist()) {
                res.process('unlock.html', null, next);
            } else {
              Severity: Major
              Found in lib/routes.js and 1 other location - About 1 hr to fix
              lib/routes.js on lines 138..146

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      youtransfer.settings.finalise(req.params.settings.state.unlockCode, function(err) {
            req.errors.parse(err);
            if(req.errors.exist()) {
                res.process('settings.finalise.html', null, next);
            } else {
              Severity: Major
              Found in lib/routes.js and 1 other location - About 1 hr to fix
              lib/routes.js on lines 160..168

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 74.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if(self.encryptionEnabled && self.encryptionKey) {
            var cipher = crypto.createCipher('aes-256-ctr', self.encryptionKey);
            readStream.pipe(cipher)
                      .pipe(writeStream);
        } else {
              Severity: Major
              Found in lib/localstorage.js and 1 other location - About 1 hr to fix
              lib/localstorage.js on lines 200..206

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                  if(self.encryptionEnabled && self.encryptionKey) {
                        var decipher = crypto.createDecipher('aes-256-ctr', self.encryptionKey);
                        filestream.pipe(decipher)
                                  .pipe(res);
                    } else {
              Severity: Major
              Found in lib/localstorage.js and 1 other location - About 1 hr to fix
              lib/localstorage.js on lines 72..78

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function render has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  res.render = function(name, context, callback) {
        callback = callback || function() {};
        res.setHeader('Server', 'youtransfer.io');

        youtransfer.settings.get(function(err, settings) {
              Severity: Minor
              Found in lib/middleware.js - About 1 hr to fix

                Function send has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    self.send = function(req, res, next) {
        self.settings.get(function(err, settings) {
            if(!err) {
                var fields = _.clone(req.params);
                fields.baseUrl = settings.general.baseUrl;
                Severity: Minor
                Found in lib/youtransfer.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language