Zeuskartik/MediaSliderView

View on GitHub

Showing 23 of 23 total issues

File TouchImageView.java has 913 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.zeuskartik.mediaslider;

import android.annotation.TargetApi;
import android.content.Context;
import android.content.res.Configuration;

    TouchImageView has 56 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class TouchImageView extends AppCompatImageView {
    
        private static final String DEBUG = "DEBUG";
    
        //

      Method initViewsAndSetAdapter has 90 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void initViewsAndSetAdapter() {
              RelativeLayout statusLayout = findViewById(R.id.status_holder);
              TextView slider_title = findViewById(R.id.title);
              slider_media_number = findViewById(R.id.number);
              ImageView left = findViewById(R.id.left_arrow);

        Method fitImageToView has 74 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void fitImageToView() {
                FixedPixel fixedPixel = orientationJustChanged ?
                        orientationChangeFixedPixel : viewSizeChangeFixedPixel;
                orientationJustChanged = false;
        
        

          Method fitImageToView has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
          Open

              private void fitImageToView() {
                  FixedPixel fixedPixel = orientationJustChanged ?
                          orientationChangeFixedPixel : viewSizeChangeFixedPixel;
                  orientationJustChanged = false;
          
          

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setMinZoom has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public void setMinZoom(float min) {
                  userSpecifiedMinScale = min;
                  if (min == AUTOMATIC_MIN_ZOOM) {
                      if (mScaleType == ScaleType.CENTER || mScaleType == ScaleType.CENTER_CROP) {
                          Drawable drawable = getDrawable();

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initViewsAndSetAdapter has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

              private void initViewsAndSetAdapter() {
                  RelativeLayout statusLayout = findViewById(R.id.status_holder);
                  TextView slider_title = findViewById(R.id.title);
                  slider_media_number = findViewById(R.id.number);
                  ImageView left = findViewById(R.id.left_arrow);

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onTouch has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

                  @Override
                  public boolean onTouch(View v, MotionEvent event) {
                      if (getDrawable() == null) {
                          setState(State.NONE);
                          return false;

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onTouch has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  @Override
                  public boolean onTouch(View v, MotionEvent event) {
                      if (getDrawable() == null) {
                          setState(State.NONE);
                          return false;

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @Override
                public boolean canScrollVertically(int direction) {
                    matrix.getValues(m);
                    float y = m[Matrix.MTRANS_Y];
            
            
            mediaslider/src/main/java/com/zeuskartik/mediaslider/TouchImageView.java on lines 917..933

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 102.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                @Override
                public boolean canScrollHorizontally(int direction) {
                    matrix.getValues(m);
                    float x = m[Matrix.MTRANS_X];
            
            
            mediaslider/src/main/java/com/zeuskartik/mediaslider/TouchImageView.java on lines 935..951

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 102.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method instantiateItem has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    @NonNull
                    @Override
                    public Object instantiateItem(@NonNull ViewGroup container, int position) {
                        LayoutInflater inflater = (LayoutInflater) context.getSystemService(context.LAYOUT_INFLATER_SERVICE);
                        View view = null;

              Method configureImageView has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void configureImageView(Context context, AttributeSet attrs, int defStyleAttr) {
                      this.context = context;
              
                      super.setClickable(true);
              
              

                Method loadMediaSliderView has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void loadMediaSliderView(ArrayList<String> mediaUrlList, String mediaType, boolean isTitleVisible, boolean isMediaCountVisible, boolean isNavigationVisible, String title, String titleBackgroundColor, String titleTextColor, int startPosition) {

                  Method fling has 8 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          void fling(int startX, int startY, int velocityX, int velocityY, int minX, int maxX, int minY, int maxY) {

                    Method onDoubleTap has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                            @Override
                            public boolean onDoubleTap(MotionEvent e) {
                                boolean consumed = false;
                                if (isZoomEnabled()) {
                                    if (doubleTapListener != null) {
                    Severity: Minor
                    Found in mediaslider/src/main/java/com/zeuskartik/mediaslider/TouchImageView.java - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method newTranslationAfterChange has 7 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        private float newTranslationAfterChange(float trans, float prevImageSize, float imageSize, int prevViewSize, int viewSize, int drawableSize, FixedPixel sizeChangeFixedPixel) {
                    Severity: Major
                    Found in mediaslider/src/main/java/com/zeuskartik/mediaslider/TouchImageView.java - About 50 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  left.setOnClickListener(new View.OnClickListener() {
                                      @Override
                                      public void onClick(View v) {
                                          int i = mPager.getCurrentItem();
                                          mPager.setCurrentItem(i - 1);
                      mediaslider/src/main/java/com/zeuskartik/mediaslider/MediaSliderActivity.java on lines 132..140

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 60.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  right.setOnClickListener(new View.OnClickListener() {
                                      @Override
                                      public void onClick(View v) {
                                          int i = mPager.getCurrentItem();
                                          mPager.setCurrentItem(i + 1);
                      mediaslider/src/main/java/com/zeuskartik/mediaslider/MediaSliderActivity.java on lines 122..131

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 60.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Method onResourceReady has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                                          public boolean onResourceReady(Drawable resource, Object model, Target<Drawable> target, DataSource dataSource, boolean isFirstResource) {
                        Severity
                        Category
                        Status
                        Source
                        Language