Sign upLogin

ZuluPro/myblog

View on GitHub
Star
myblog/myapp/static/zinnia/js/foundation/foundation.tab.js

Summary

Maintainability
A
4 hrs
Test Coverage

Function toggle_active_tab has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    toggle_active_tab: function (tab, location_hash) {
      var S = this.S,
          tabs = tab.closest('[' + this.attr_name() + ']'),
          anchor = tab.children('a').first(),
          target_hash = '#' + anchor.attr('href').split('#')[1],
Severity: Minor
Found in myblog/myapp/static/zinnia/js/foundation/foundation.tab.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              var settings = S(this).closest('[' + self.attr_name() +']').data(self.attr_name(true) + '-init');
    Severity: Minor
    Found in myblog/myapp/static/zinnia/js/foundation/foundation.tab.js and 1 other location - About 55 mins to fix
    myblog/myapp/static/zinnia/js/foundation/foundation.tab.js on lines 42..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

              var settings = S(this).closest('[' + self.attr_name() +']').data(self.attr_name(true) + '-init');
    Severity: Minor
    Found in myblog/myapp/static/zinnia/js/foundation/foundation.tab.js and 1 other location - About 55 mins to fix
    myblog/myapp/static/zinnia/js/foundation/foundation.tab.js on lines 51..51

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        data_attr: function (str) {
      if (this.namespace.length > 0) {
        return this.namespace + '-' + str;
      }
    Severity: Minor
    Found in myblog/myapp/static/zinnia/js/foundation/foundation.tab.js and 2 other locations - About 40 mins to fix
    myblog/myapp/static/zinnia/js/foundation/foundation.magellan.js on lines 170..176
    myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js on lines 404..410

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status