Sign upLogin

abrain/einsatzverwaltung

View on GitHub
Star

Showing 247 of 250 total issues

File Renderer.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace abrain\Einsatzverwaltung\Frontend\ReportList;

use abrain\Einsatzverwaltung\Frontend\AnnotationIconBar;
use abrain\Einsatzverwaltung\Model\IncidentReport;
Severity: Minor
Found in src/Frontend/ReportList/Renderer.php - About 3 hrs to fix

    Function doUpdate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public function doUpdate(int $currentDbVersion, int $targetDbVersion)
    {
        if (empty($targetDbVersion)) {
            return new WP_Error('', 'Zieldatenbankversion darf nicht leer sein');
        }
    Severity: Minor
    Found in src/Update.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method registerPostMeta has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function registerPostMeta()
    {
        register_meta('post', 'einsatz_einsatzende', array(
            'object_subtype' => self::getSlug(),
            'type' => 'string',
    Severity: Major
    Found in src/Types/Report.php - About 2 hrs to fix

      Function getCellContent has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          private function getCellContent($report, $colId, Parameters $parameters): string
    {
        if (empty($report)) {
            return '&nbsp;';
        }
      Severity: Minor
      Found in src/Frontend/ReportList/Renderer.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getCellContent has 71 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getCellContent($report, $colId, Parameters $parameters): string
    {
        if (empty($report)) {
            return '&nbsp;';
        }
      Severity: Major
      Found in src/Frontend/ReportList/Renderer.php - About 2 hrs to fix

        Method displayMetaBoxEinsatzdetails has 71 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function displayMetaBoxEinsatzdetails(WP_Post $post)
    {
        // Use nonce for verification
        wp_nonce_field('save_einsatz_details', 'einsatzverwaltung_nonce');
        Severity: Major
        Found in src/Admin/ReportEditScreen.php - About 2 hrs to fix

          Method register_routes has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function register_routes() // phpcs:ignore PSR1.Methods.CamelCapsMethodName.NotCamelCaps -- overridden method
    {
        $namespace = 'einsatzverwaltung/v1';
        register_rest_route($namespace, '/reports', array(
            array(
          Severity: Major
          Found in src/Api/Reports.php - About 2 hrs to fix

            File RecentIncidentsFormatted.php has 278 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
namespace abrain\Einsatzverwaltung\Widgets;

use abrain\Einsatzverwaltung\ReportQuery;
use abrain\Einsatzverwaltung\Types\Unit;
            Severity: Minor
            Found in src/Widgets/RecentIncidentsFormatted.php - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function addHooks()
    {
        add_action('save_post_einsatz', array($this, 'savePostdata'), 10, 2);
        add_action('private_einsatz', array($this, 'onPublish'), 10, 2);
        add_action('publish_einsatz', array($this, 'onPublish'), 10, 2);
              Severity: Major
              Found in src/Data.php and 1 other location - About 2 hrs to fix
              src/ReportNumberController.php on lines 46..53

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 134.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function addHooks()
    {
        add_action('updated_postmeta', array($this, 'onPostMetaChanged'), 10, 4);
        add_action('added_post_meta', array($this, 'onPostMetaChanged'), 10, 4);
        add_action('updated_option', array($this, 'maybeAutoIncidentNumbersChanged'), 10, 3);
              Severity: Major
              Found in src/ReportNumberController.php and 1 other location - About 2 hrs to fix
              src/Data.php on lines 61..68

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 134.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File IncidentReport.php has 276 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

namespace abrain\Einsatzverwaltung\Model;

use abrain\Einsatzverwaltung\Types\AlertingMethod;
              Severity: Minor
              Found in src/Model/IncidentReport.php - About 2 hrs to fix

                Function readFile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function readFile($numLines = null, $requestedFields = array())
    {
        $fieldMap = array();
        if (!empty($requestedFields)) {
            $fields = $this->getFields();
                Severity: Minor
                Found in src/Import/Sources/Csv.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method doUpdate has 63 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function doUpdate(int $currentDbVersion, int $targetDbVersion)
    {
        if (empty($targetDbVersion)) {
            return new WP_Error('', 'Zieldatenbankversion darf nicht leer sein');
        }
                Severity: Major
                Found in src/Update.php - About 2 hrs to fix

                  Method savePostdata has 61 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function savePostdata(int $postId, WP_Post $post)
    {
        // Schreibrechte prüfen
        if (!current_user_can('edit_einsatzbericht', $postId)) {
            return;
                  Severity: Major
                  Found in src/Data.php - About 2 hrs to fix

                    Function upgrade180 has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function upgrade180()
    {
        // Rewrite post_type to evw_legacy_unit
        global $wpdb;
        $query = $wpdb->prepare("UPDATE $wpdb->posts SET post_type = %s WHERE post_type = %s", 'evw_legacy_unit', 'evw_unit');
                    Severity: Minor
                    Found in src/Update.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function savePostdata has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function savePostdata(int $postId, WP_Post $post)
    {
        // Schreibrechte prüfen
        if (!current_user_can('edit_einsatzbericht', $postId)) {
            return;
                    Severity: Minor
                    Found in src/Data.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method enqueueEditScripts has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function enqueueEditScripts($hook)
    {
        if ('post.php' == $hook || 'post-new.php' == $hook) {
            // Nur auf der Bearbeitungsseite anzeigen
            wp_enqueue_script(
                    Severity: Major
                    Found in src/Admin/Initializer.php - About 2 hrs to fix

                      Method form has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function form($instance): string
    {
        $values = wp_parse_args($instance, $this->defaults);

        echo '<p>';
                      Severity: Major
                      Found in src/Widgets/RecentIncidentsFormatted.php - About 2 hrs to fix

                        AbstractSource has 21 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        abstract class AbstractSource
{
    /**
     * @var Utilities
     */
                        Severity: Minor
                        Found in src/Import/Sources/AbstractSource.php - About 2 hrs to fix

                          Update has 21 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class Update
{
    /**
     * Fürt ein Update der Datenbank duch
     *
                          Severity: Minor
                          Found in src/Update.php - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language