abrain/einsatzverwaltung

View on GitHub
src/Frontend/ReportList/Renderer.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

The class Renderer has an overall complexity of 71 which is very high. The configured complexity threshold is 50.
Open

class Renderer
{
    const TABLECLASS = 'einsatzverwaltung-reportlist';

    /**
Severity: Minor
Found in src/Frontend/ReportList/Renderer.php by phpmd

File Renderer.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace abrain\Einsatzverwaltung\Frontend\ReportList;

use abrain\Einsatzverwaltung\Frontend\AnnotationIconBar;
use abrain\Einsatzverwaltung\Model\IncidentReport;
Severity: Minor
Found in src/Frontend/ReportList/Renderer.php - About 3 hrs to fix

    Function getCellContent has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

        private function getCellContent($report, $colId, Parameters $parameters): string
        {
            if (empty($report)) {
                return '&nbsp;';
            }
    Severity: Minor
    Found in src/Frontend/ReportList/Renderer.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getCellContent has 71 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function getCellContent($report, $colId, Parameters $parameters): string
        {
            if (empty($report)) {
                return '&nbsp;';
            }
    Severity: Major
    Found in src/Frontend/ReportList/Renderer.php - About 2 hrs to fix

      Method constructList has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function constructList($reports, Parameters $parameters)
          {
              if (empty($reports)) {
                  $this->string = sprintf(
                      '<span>%s</span>',
      Severity: Minor
      Found in src/Frontend/ReportList/Renderer.php - About 1 hr to fix

        Function constructList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            private function constructList($reports, Parameters $parameters)
            {
                if (empty($reports)) {
                    $this->string = sprintf(
                        '<span>%s</span>',
        Severity: Minor
        Found in src/Frontend/ReportList/Renderer.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getSmallScreenCell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function getSmallScreenCell(IncidentReport $report, Parameters $parameters): string
            {
                $content = '';
                $annotations = '';
        
        
        Severity: Minor
        Found in src/Frontend/ReportList/Renderer.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method getCellContent() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
        Open

            private function getCellContent($report, $colId, Parameters $parameters): string
            {
                if (empty($report)) {
                    return '&nbsp;';
                }
        Severity: Minor
        Found in src/Frontend/ReportList/Renderer.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        There are no issues that match your filters.

        Category
        Status