abrain/einsatzverwaltung

View on GitHub
src/Import/Sources/Csv.php

Summary

Maintainability
B
6 hrs
Test Coverage
F
0%

Function readFile has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    private function readFile($numLines = null, $requestedFields = array())
    {
        $fieldMap = array();
        if (!empty($requestedFields)) {
            $fields = $this->getFields();
Severity: Minor
Found in src/Import/Sources/Csv.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method readFile has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function readFile($numLines = null, $requestedFields = array())
    {
        $fieldMap = array();
        if (!empty($requestedFields)) {
            $fields = $this->getFields();
Severity: Minor
Found in src/Import/Sources/Csv.php - About 1 hr to fix

    Method checkPreconditions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function checkPreconditions()
        {
            $this->fileHasHeadlines = (bool) Utilities::getArrayValueIfKey($this->args, 'has_headlines', false);
    
            $delimiter = Utilities::getArrayValueIfKey($this->args, 'delimiter', false);
    Severity: Minor
    Found in src/Import/Sources/Csv.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in src/Import/Sources/Csv.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/Import/Sources/Csv.php - About 30 mins to fix

          Function checkPreconditions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function checkPreconditions()
              {
                  $this->fileHasHeadlines = (bool) Utilities::getArrayValueIfKey($this->args, 'has_headlines', false);
          
                  $delimiter = Utilities::getArrayValueIfKey($this->args, 'delimiter', false);
          Severity: Minor
          Found in src/Import/Sources/Csv.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method readFile() has an NPath complexity of 456. The configured NPath complexity threshold is 200.
          Open

              private function readFile($numLines = null, $requestedFields = array())
              {
                  $fieldMap = array();
                  if (!empty($requestedFields)) {
                      $fields = $this->getFields();
          Severity: Minor
          Found in src/Import/Sources/Csv.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method readFile() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
          Open

              private function readFile($numLines = null, $requestedFields = array())
              {
                  $fieldMap = array();
                  if (!empty($requestedFields)) {
                      $fields = $this->getFields();
          Severity: Minor
          Found in src/Import/Sources/Csv.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid using abrain\Einsatzverwaltung\Import\Sources\count() function in while loops.
          Open

                  while (null === $numLines || count($lines) < $numLines) {
                      $line = fgetcsv($handle, 0, $this->delimiter, $this->enclosure);
          
                      // Problem beim Lesen oder Ende der Datei
                      if (empty($line)) {
          Severity: Minor
          Found in src/Import/Sources/Csv.php by phpmd

          CountInLoopExpression

          Since: 2.7.0

          Using count/sizeof in loops expressions is considered bad practice and is a potential source of many bugs, especially when the loop manipulates an array, as count happens on each iteration.

          Example

          class Foo {
          
            public function bar()
            {
              $array = array();
          
              for ($i = 0; count($array); $i++) {
                // ...
              }
            }
          }

          Source https://phpmd.org/rules/design.html#countinloopexpression

          There are no issues that match your filters.

          Category
          Status