abrain/einsatzverwaltung

View on GitHub
src/Import/Tool.php

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Method renderToolPage has 106 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function renderToolPage()
    {
        $this->helper = new Helper($this->utilities, $this->data);
        $this->helper->metaFields = IncidentReport::getMetaFields();
        $this->helper->taxonomies = IncidentReport::getTerms();
Severity: Major
Found in src/Import/Tool.php - About 4 hrs to fix

    Function renderToolPage has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

        public function renderToolPage()
        {
            $this->helper = new Helper($this->utilities, $this->data);
            $this->helper->metaFields = IncidentReport::getMetaFields();
            $this->helper->taxonomies = IncidentReport::getTerms();
    Severity: Minor
    Found in src/Import/Tool.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method analysisPage has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function analysisPage()
        {
            if (!$this->currentSource->checkPreconditions()) {
                return;
            }
    Severity: Minor
    Found in src/Import/Tool.php - About 1 hr to fix

      Method importPage has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function importPage()
          {
              if (!$this->currentSource->checkPreconditions()) {
                  return;
              }
      Severity: Minor
      Found in src/Import/Tool.php - About 1 hr to fix

        Function analysisPage has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function analysisPage()
            {
                if (!$this->currentSource->checkPreconditions()) {
                    return;
                }
        Severity: Minor
        Found in src/Import/Tool.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return;
        Severity: Major
        Found in src/Import/Tool.php - About 30 mins to fix

          The method renderToolPage() has 137 lines of code. Current threshold is set to 100. Avoid really long methods.
          Open

              public function renderToolPage()
              {
                  $this->helper = new Helper($this->utilities, $this->data);
                  $this->helper->metaFields = IncidentReport::getMetaFields();
                  $this->helper->taxonomies = IncidentReport::getTerms();
          Severity: Minor
          Found in src/Import/Tool.php by phpmd

          The method renderToolPage() has an NPath complexity of 4125. The configured NPath complexity threshold is 200.
          Open

              public function renderToolPage()
              {
                  $this->helper = new Helper($this->utilities, $this->data);
                  $this->helper->metaFields = IncidentReport::getMetaFields();
                  $this->helper->taxonomies = IncidentReport::getTerms();
          Severity: Minor
          Found in src/Import/Tool.php by phpmd

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method renderToolPage() has a Cyclomatic Complexity of 20. The configured cyclomatic complexity threshold is 10.
          Open

              public function renderToolPage()
              {
                  $this->helper = new Helper($this->utilities, $this->data);
                  $this->helper->metaFields = IncidentReport::getMetaFields();
                  $this->helper->taxonomies = IncidentReport::getTerms();
          Severity: Minor
          Found in src/Import/Tool.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          TODO found
          Open

                  // TODO gemeinsame Prüfungen auslagern
          Severity: Minor
          Found in src/Import/Tool.php by fixme

          There are no issues that match your filters.

          Category
          Status