abrain/einsatzverwaltung

View on GitHub
src/Update.php

Summary

Maintainability
F
3 days
Test Coverage
A
94%

File Update.php has 484 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
namespace abrain\Einsatzverwaltung;

use WP_Error;
use WP_User;
Severity: Minor
Found in src/Update.php - About 7 hrs to fix

    The class Update has an overall complexity of 112 which is very high. The configured complexity threshold is 50.
    Open

    class Update
    {
        /**
         * Fürt ein Update der Datenbank duch
         *
    Severity: Minor
    Found in src/Update.php by phpmd

    Function doUpdate has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public function doUpdate(int $currentDbVersion, int $targetDbVersion)
        {
            if (empty($targetDbVersion)) {
                return new WP_Error('', 'Zieldatenbankversion darf nicht leer sein');
            }
    Severity: Minor
    Found in src/Update.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method doUpdate has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function doUpdate(int $currentDbVersion, int $targetDbVersion)
        {
            if (empty($targetDbVersion)) {
                return new WP_Error('', 'Zieldatenbankversion darf nicht leer sein');
            }
    Severity: Major
    Found in src/Update.php - About 2 hrs to fix

      Function upgrade180 has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public function upgrade180()
          {
              // Rewrite post_type to evw_legacy_unit
              global $wpdb;
              $query = $wpdb->prepare("UPDATE $wpdb->posts SET post_type = %s WHERE post_type = %s", 'evw_legacy_unit', 'evw_unit');
      Severity: Minor
      Found in src/Update.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Update has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Update
      {
          /**
           * Fürt ein Update der Datenbank duch
           *
      Severity: Minor
      Found in src/Update.php - About 2 hrs to fix

        Method upgrade120 has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function upgrade120()
            {
                global $wpdb;
        
                // Alle veröffentlichten Einsatzberichte einer Kategorie hinzufügen, wenn diese in den Einstellungen für die
        Severity: Major
        Found in src/Update.php - About 2 hrs to fix

          Method upgrade180 has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function upgrade180()
              {
                  // Rewrite post_type to evw_legacy_unit
                  global $wpdb;
                  $query = $wpdb->prepare("UPDATE $wpdb->posts SET post_type = %s WHERE post_type = %s", 'evw_legacy_unit', 'evw_unit');
          Severity: Minor
          Found in src/Update.php - About 2 hrs to fix

            Function upgrade1100 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                public function upgrade1100()
                {
                    add_option('einsatzvw_category', '-1');
            
                    // Get roles and check if they were allowed to edit reports before
            Severity: Minor
            Found in src/Update.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function upgrade130 has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                private function upgrade130()
                {
                    global $wpdb;
            
                    $taxonomies = array(
            Severity: Minor
            Found in src/Update.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function upgrade120 has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                private function upgrade120()
                {
                    global $wpdb;
            
                    // Alle veröffentlichten Einsatzberichte einer Kategorie hinzufügen, wenn diese in den Einstellungen für die
            Severity: Minor
            Found in src/Update.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method upgrade130 has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function upgrade130()
                {
                    global $wpdb;
            
                    $taxonomies = array(
            Severity: Minor
            Found in src/Update.php - About 1 hr to fix

              Method upgrade113 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function upgrade113()
                  {
                      if (!function_exists('get_editable_roles')) {
                          require_once(ABSPATH . 'wp-admin/includes/user.php');
                      }
              Severity: Minor
              Found in src/Update.php - About 1 hr to fix

                Function upgrade162 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function upgrade162()
                    {
                        global $wpdb;
                
                        /**
                Severity: Minor
                Found in src/Update.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function upgrade170 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function upgrade170()
                    {
                        global $wpdb;
                
                        /**
                Severity: Minor
                Found in src/Update.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function upgrade113 has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function upgrade113()
                    {
                        if (!function_exists('get_editable_roles')) {
                            require_once(ABSPATH . 'wp-admin/includes/user.php');
                        }
                Severity: Minor
                Found in src/Update.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                The method doUpdate() has an NPath complexity of 2324522934. The configured NPath complexity threshold is 200.
                Open

                    public function doUpdate(int $currentDbVersion, int $targetDbVersion)
                    {
                        if (empty($targetDbVersion)) {
                            return new WP_Error('', 'Zieldatenbankversion darf nicht leer sein');
                        }
                Severity: Minor
                Found in src/Update.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method upgrade180() has an NPath complexity of 222. The configured NPath complexity threshold is 200.
                Open

                    public function upgrade180()
                    {
                        // Rewrite post_type to evw_legacy_unit
                        global $wpdb;
                        $query = $wpdb->prepare("UPDATE $wpdb->posts SET post_type = %s WHERE post_type = %s", 'evw_legacy_unit', 'evw_unit');
                Severity: Minor
                Found in src/Update.php by phpmd

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method upgrade180() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                Open

                    public function upgrade180()
                    {
                        // Rewrite post_type to evw_legacy_unit
                        global $wpdb;
                        $query = $wpdb->prepare("UPDATE $wpdb->posts SET post_type = %s WHERE post_type = %s", 'evw_legacy_unit', 'evw_unit');
                Severity: Minor
                Found in src/Update.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method doUpdate() has a Cyclomatic Complexity of 40. The configured cyclomatic complexity threshold is 10.
                Open

                    public function doUpdate(int $currentDbVersion, int $targetDbVersion)
                    {
                        if (empty($targetDbVersion)) {
                            return new WP_Error('', 'Zieldatenbankversion darf nicht leer sein');
                        }
                Severity: Minor
                Found in src/Update.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                The method upgrade120() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                Open

                    private function upgrade120()
                    {
                        global $wpdb;
                
                        // Alle veröffentlichten Einsatzberichte einer Kategorie hinzufügen, wenn diese in den Einstellungen für die
                Severity: Minor
                Found in src/Update.php by phpmd

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                There are no issues that match your filters.

                Category
                Status