accessd/rails-settings-ui

View on GitHub

Showing 2 of 2 total issues

Method update_all has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def update_all
    if @casted_settings[:errors].any?
      @errors = @casted_settings[:errors]
      render :index
    else
Severity: Minor
Found in app/controllers/rails_settings_ui/settings_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_non_presented_settings has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.set_non_presented_settings(settings)
      RailsSettingsUi.default_settings.each do |name, value|
        if !settings[name.to_sym].present?
          if [TrueClass, FalseClass].include?(value.class)
            settings[name.to_sym] = false
Severity: Minor
Found in lib/rails-settings-ui/type_converter.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language