acooks/jittertrap

View on GitHub
html5-client/src/js/jittertrap-chart-tput.js

Summary

Maintainability
C
1 day
Test Coverage

Function tputChart has 126 lines of code (exceeds 50 allowed). Consider refactoring.
Open

  my.charts.tput.tputChart = (function (m) {
    var margin = {
      top: 20,
      right: 20,
      bottom: 40,
Severity: Major
Found in html5-client/src/js/jittertrap-chart-tput.js - About 4 hrs to fix

    Function reset has 69 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

        m.reset = function(selectedSeries) {
    
          d3.select("#chartThroughput").selectAll("svg").remove();
    
          svg = d3.select("#chartThroughput")
    Severity: Major
    Found in html5-client/src/js/jittertrap-chart-tput.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            graph.append("text")
                 .attr("class", "x label")
                 .attr("text-anchor", "middle")
                 .attr("x", width/2)
                 .attr("y", height + 15 + 0.5 * margin.bottom)
      Severity: Major
      Found in html5-client/src/js/jittertrap-chart-tput.js and 1 other location - About 1 hr to fix
      html5-client/src/js/jittertrap-chart-pgaps.js on lines 104..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            svg.attr("width", width + margin.left + margin.right)
               .attr("height", height + margin.top + margin.bottom);
      Severity: Minor
      Found in html5-client/src/js/jittertrap-chart-tput.js and 1 other location - About 55 mins to fix
      html5-client/src/js/jittertrap-chart-pgaps.js on lines 86..87

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

            var graph = svg.append("g")
               .attr("transform", "translate(" + margin.left + "," + margin.top + ")");
      Severity: Minor
      Found in html5-client/src/js/jittertrap-chart-tput.js and 2 other locations - About 40 mins to fix
      html5-client/src/js/jittertrap-chart-pgaps.js on lines 89..90
      html5-client/src/js/jittertrap-chart-toptalk.js on lines 114..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status