Sign upLogin

activemerchant/active_merchant

View on GitHub
Star
lib/active_merchant/billing/gateways/authorize_net_arb.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class AuthorizeNetArbGateway has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

    class AuthorizeNetArbGateway < Gateway
      API_VERSION = '3.1'

      self.test_url = 'https://apitest.authorize.net/xml/v1/request.api'
      self.live_url = 'https://api.authorize.net/xml/v1/request.api'
Severity: Minor
Found in lib/active_merchant/billing/gateways/authorize_net_arb.rb - About 3 hrs to fix

    Method add_customer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_customer(xml, options)
        customer = options[:customer]
        return unless customer

        xml.tag!('customer') do
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/authorize_net_arb.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_subscription has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_subscription(xml, options)
        xml.tag!('subscription') do
          # Merchant-assigned name for the subscription (optional)
          xml.tag!('name', options[:subscription_name]) if options[:subscription_name]
          # Contains information about the payment schedule
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/authorize_net_arb.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_payment_schedule has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_payment_schedule(xml, options)
        return unless options[:interval] || options[:duration]

        xml.tag!('paymentSchedule') do
          # Contains information about the interval of time between payments
    Severity: Minor
    Found in lib/active_merchant/billing/gateways/authorize_net_arb.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status