activescaffold/active_scaffold

View on GitHub
app/assets/javascripts/jquery/jquery.editinplace.js

Summary

Maintainability
D
1 day
Test Coverage

File jquery.editinplace.js has 543 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*

A jQuery edit in place plugin

Version 2.2.0
Severity: Major
Found in app/assets/javascripts/jquery/jquery.editinplace.js - About 1 day to fix

    Function handleSubmitToServer has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        handleSubmitToServer: function(enteredText) {
            var data = '';
            if (typeof(enteredText) === 'string') {
                data += this.settings.update_value + '=' + encodeURIComponent(enteredText) + '&';
            } else {
    Severity: Minor
    Found in app/assets/javascripts/jquery/jquery.editinplace.js - About 1 hr to fix

      Function handleSaveEditor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          handleSaveEditor: function(anEvent) {
              if (false === this.triggerDelegateCall('shouldCloseEditInPlace', true, anEvent))
                  return;
      
              var editor = this.dom.find('[name]:input:not(:button,[name=""])').not('input:checkbox:not(:checked)').not('input:radio:not(:checked)');
      Severity: Minor
      Found in app/assets/javascripts/jquery/jquery.editinplace.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            addHoverEffect: function() {
                if (this.settings.hover_class)
                    this.dom.addClass(this.settings.hover_class);
                else
                    this.dom.css("background-color", this.settings.bg_over);
        Severity: Major
        Found in app/assets/javascripts/jquery/jquery.editinplace.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/jquery/jquery.editinplace.js on lines 171..176

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            removeHoverEffect: function() {
                if (this.settings.hover_class)
                    this.dom.removeClass(this.settings.hover_class);
                else
                    this.dom.css("background-color", this.settings.bg_out);
        Severity: Major
        Found in app/assets/javascripts/jquery/jquery.editinplace.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/jquery/jquery.editinplace.js on lines 164..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status