Sign upLogin

ademin/mailru-api

View on GitHub
Star

Showing 3 of 3 total issues

Method handle_response has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def handle_response response
        response = response.body unless response.is_a?(String)

        if @api.format == Format::XML
          response = REXML::Document.new(response).root
Severity: Minor
Found in lib/mailru/api/request.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def parameters
        params = {}
        params.merge!({app_id: @api.app_id}) if @api.app_id
        params.merge!({method: @method}) if @method
        params.merge!({session_key: @api.session_key}) if @api.session_key
Severity: Minor
Found in lib/mailru/api/request.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method api has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def api name, method = :get, secure = Request::Secure::Any
        raise Error.create(0, 'HTTP method must be GET or POST!') unless [:get, :post].include?(method)

        __send__(:define_singleton_method, underscore(name)) do |params = {}|
          return @api.get("#{@group}.#{name}", params, secure) if method == :get
Severity: Minor
Found in lib/mailru/api/dsl.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language