adobe/brackets

View on GitHub
src/extensions/default/CodeFolding/foldhelpers/foldgutter.js

Summary

Maintainability
C
1 day
Test Coverage

File foldgutter.js has 255 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// CodeMirror, copyright (c) by Marijn Haverbeke and others
// Distributed under an MIT license: http://codemirror.net/LICENSE
// Based on http://codemirror.net/addon/fold/foldgutter.js
// Modified by Patrick Oladimeji for Brackets

Severity: Minor
Found in src/extensions/default/CodeFolding/foldhelpers/foldgutter.js - About 2 hrs to fix

    Function updateFoldInfo has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function updateFoldInfo(cm, from, to) {
            var minFoldSize = prefs.getSetting("minFoldSize") || 2;
            var opts = cm.state.foldGutter.options;
            var fade = prefs.getSetting("hideUntilMouseover");
            var $gutter = $(cm.getGutterElement());
    Severity: Major
    Found in src/extensions/default/CodeFolding/foldhelpers/foldgutter.js - About 2 hrs to fix

      Function updateFoldsCache has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function updateFoldsCache(cm, from, linesDiff) {
              var oldRange, newRange;
              var minFoldSize = prefs.getSetting("minFoldSize") || 2;
              var foldedLines = Object.keys(cm._lineFolds).map(function (d) {
                  return +d;
      Severity: Minor
      Found in src/extensions/default/CodeFolding/foldhelpers/foldgutter.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                                if (range) {
                                    mark = marker(opts.indicatorFolded);
                                } else {
                                    cm.findMarksAt(pos).filter(isFold)
                                        .forEach(clear);
        Severity: Major
        Found in src/extensions/default/CodeFolding/foldhelpers/foldgutter.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (range && range.to.line - range.from.line >= minFoldSize) {
                                      mark = marker(opts.indicatorOpen);
                                  }
          Severity: Major
          Found in src/extensions/default/CodeFolding/foldhelpers/foldgutter.js - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (range && range.to.line - range.from.line >= minFoldSize) {
                                cm._lineFolds[i] = range;
                                i = range.to.line;
                            } else {
                                delete cm._lineFolds[i];
            Severity: Major
            Found in src/extensions/default/CodeFolding/foldhelpers/foldgutter.js and 1 other location - About 2 hrs to fix
            src/extensions/default/CodeFolding/unittest-files/test.js on lines 27..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status