Sign upLogin

ahmadsoe/ember-highcharts

View on GitHub
Star

Showing 3 of 3 total issues

Function included has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

  included(app) {
    this._super.included.apply(this, arguments);

    // The app argument passed to included is the host app or parent addon.
    // And the addon has a `import` api exposed since ember-cli/ember-cli#5877.
Severity: Minor
Found in index.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function included has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  included(app) {
    this._super.included.apply(this, arguments);

    // The app argument passed to included is the host app or parent addon.
    // And the addon has a `import` api exposed since ember-cli/ember-cli#5877.
Severity: Minor
Found in index.js - About 1 hr to fix

    Function onDidUpdate has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      @action
  onDidUpdate(elem, positionalArgs, { content, chartOptions, mode}) {
    const { chart } = this;

    if (!content || !chart) {
    Severity: Minor
    Found in addon/components/high-charts.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language