Sign upLogin

aidamanna/appetype

View on GitHub
Star

Showing 4 of 6 total issues

Method set_default_values has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def set_default_values
    self.state ||= 'draft'
    self.daily_menus ||= {
      monday: {
        side_dish: '',
Severity: Minor
Found in app/models/menu.rb - About 1 hr to fix

    Method daily_menus has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def daily_menus
      {
        monday: {
          side_dish: params[:monday_side_dish],
          omni: params[:monday_omni],
    Severity: Minor
    Found in app/controllers/menus/create_controller.rb - About 1 hr to fix

      Method daily_menus has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def daily_menus
      {
        monday: {
          side_dish: params[:monday_side_dish],
          omni: params[:monday_omni],
      Severity: Minor
      Found in app/controllers/menus/update_controller.rb - About 1 hr to fix

        Method call has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def call
      @menu = Menu.find(menu_id)
      raise Error::MenuStatus, 'The menu status is not draft and cannot be updated' unless @menu.draft?
      if @menu.update(daily_menus: daily_menus)
        flash[:success] = 'Menu updated.'
        Severity: Minor
        Found in app/controllers/menus/update_controller.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language