airbnb/caravel

View on GitHub
superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js

Summary

Maintainability
D
2 days
Test Coverage

File utils.js has 361 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
Severity: Minor
Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js - About 4 hrs to fix

    Function drawBarValues has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function drawBarValues(svg, data, stacked, axisFormat) {
      const format = getNumberFormatter(axisFormat);
      const countSeriesDisplayed = data.filter(d => !d.disabled).length;
      const totalStackedValues =
        stacked && data.length !== 0
    Severity: Minor
    Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js - About 1 hr to fix

      Function generateAreaChartTooltipContent has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function generateAreaChartTooltipContent(
        d,
        timeFormatter,
        valueFormatter,
        chart,
      Severity: Minor
      Found in superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          d.series.forEach(series => {
            const key = getFormattedKey(series.key, true);
            tooltip +=
              `<tr class="${series.highlight ? 'emph' : ''}">` +
              `<td class='legend-color-guide' style="opacity: ${
        superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js on lines 127..143

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 167.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          d.series.forEach(series => {
            const key = getFormattedKey(series.key, true);
            tooltip +=
              `<tr class="${series.highlight ? 'emph' : ''}">` +
              `<td class='legend-color-guide' style="opacity: ${
        superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js on lines 156..172

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 167.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              tooltip +=
                "<tr><td class='legend-color-guide'>" +
                `<div style="background-color: ${series.color};"></div></td>` +
                `<td class='key'>${label}</td>` +
                `<td class='value'>${yFormatter(series.value)}</td></tr>`;
        superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js on lines 230..234

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            tooltip +=
              "<tr><td class='legend-color-guide'>" +
              `<div style="background-color: ${series.color};"></div></td>` +
              `<td class='key'>${key}</td>` +
              `<td class='value'>${yFormatter(series.value)}</td></tr>`;
        superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js on lines 259..263

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status