alakra/ndfd-weather-forecast-client

View on GitHub

Showing 3 of 5 total issues

Method extract_weather has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

      def extract_weather
        node = element.xpath("weather")
        return if node.blank?

        node.map do |weather_node|
Severity: Minor
Found in lib/ndfd/dwml/parameter_extractor.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extract_weather has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def extract_weather
        node = element.xpath("weather")
        return if node.blank?

        node.map do |weather_node|
Severity: Minor
Found in lib/ndfd/dwml/parameter_extractor.rb - About 1 hr to fix

    Method extract_basic_time_series has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def extract_basic_time_series(metric)
            metric_node = element.xpath(metric.to_s)
            return if metric_node.blank?
    
            metric_node.map do |node|
    Severity: Minor
    Found in lib/ndfd/dwml/parameter_extractor.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language