alaouimehdi1995/django-rest

View on GitHub

Showing 10 of 10 total issues

Function _serialize has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def _serialize(self, instance, fields):
        # Transforms the `instance` object into its serialized value, by using
        # the `fields` list parameter.
        serialized_value = {}
        for name, getter, to_value, call, required, pass_self in fields:
Severity: Minor
Found in django_rest/serializers/serializers.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_function_wrapper has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

def build_function_wrapper(
    permission_class,  # type: BasePermission
    allowed_methods,  # type: Iterable[str]
    deserializers_http_methods_map,  # type: Dict[str, ClassVar[Deserializer]]
    allow_forms,  # type: bool
Severity: Minor
Found in django_rest/decorators/utils.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_function_wrapper has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

def build_function_wrapper(
Severity: Major
Found in django_rest/decorators/utils.py - About 1 hr to fix

    Function build_class_wrapper has 10 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def build_class_wrapper(
    Severity: Major
    Found in django_rest/decorators/utils.py - About 1 hr to fix

      Function _clean_fields has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def _clean_fields(self):
              if self._data in self.empty_values:
                  self._cleaned_data = self._data
                  return
              if not isinstance(self._data, dict):
      Severity: Minor
      Found in django_rest/deserializers/base.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function api_view has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def api_view(
      Severity: Major
      Found in django_rest/decorators/__init__.py - About 1 hr to fix

        Function api_view has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def api_view(
            permission_class=AllowAny,  # type: Union[AbstractPermission, Any]
            allowed_methods=ALL_METHODS,  # type: Tuple[str]
            deserializer_class=AllPassDeserializer,  # type: Union[ClassVar[Deserializer], Dict[str, ClassVar[Deserializer]]]
            allow_forms=False,  # type: bool
        Severity: Minor
        Found in django_rest/decorators/__init__.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        class IsAuthenticated(BasePermission):
            """
            Allows the view access to authenticated users only.
            """
        
        
        Severity: Minor
        Found in django_rest/permissions.py and 2 other locations - About 35 mins to fix
        django_rest/permissions.py on lines 282..289
        django_rest/permissions.py on lines 292..299

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        class IsStaffUser(BasePermission):
            """
            Allows the view access to staff users only.
            """
        
        
        Severity: Minor
        Found in django_rest/permissions.py and 2 other locations - About 35 mins to fix
        django_rest/permissions.py on lines 272..279
        django_rest/permissions.py on lines 292..299

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        class IsAdminUser(BasePermission):
            """
            Allows the view access to admin users only.
            """
        
        
        Severity: Minor
        Found in django_rest/permissions.py and 2 other locations - About 35 mins to fix
        django_rest/permissions.py on lines 272..279
        django_rest/permissions.py on lines 282..289

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language