albertyw/git-browse

View on GitHub

Showing 3 of 4 total issues

File browse.py has 295 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/usr/bin/env python3

import argparse
import configparser
import os
Severity: Minor
Found in git_browse/browse.py - About 3 hrs to fix

    Function get_git_object has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_git_object(focus_object: str, path: str, host: Any) -> GitObject:
        if not focus_object:
            return FocusObject.default()
        directory = path
        object_path = os.path.join(directory, focus_object)
    Severity: Minor
    Found in git_browse/browse.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse_git_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def parse_git_url(git_url: str, sourcegraph: bool = False) -> Any:
        for regex, host_class in HOST_REGEXES.items():
            match = re.search(regex, git_url)
            if match:
                break
    Severity: Minor
    Found in git_browse/browse.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language