Showing 3 of 3 total issues
File reviewers.py
has 271 lines of code (exceeds 250 allowed). Consider refactoring. Open
Open
#!/usr/bin/env python3
import argparse
from collections import Counter
import json
Function filter_phabricator_activated
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
Open
def filter_phabricator_activated(self, all_users: List[str]) -> List[str]:
limited_users = all_users[:REVIEWERS_LIMIT]
username_processes = [
(x, self.check_phabricator_activated(x)) for x in limited_users
]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function get_reviewers
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def get_reviewers(config): # type: (Config) -> List[str]
""" Main function to get reviewers for a repository """
phabricator = False
finders = [
FindLogReviewers,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"