albertyw/python-mailgun2

Showing 13 of 13 total issues

Cyclomatic complexity is too high in method send_message. (18) Open

``````    def send_message(self, from_email, to, cc=None, bcc=None,
subject=None, text=None, html=None, user_variables=None,
attachments=None, campaign_id=None, tags=None):
# sanity checks``````

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Function `send_message` has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open

``````    def send_message(self, from_email, to, cc=None, bcc=None,
subject=None, text=None, html=None, user_variables=None,
attachments=None, campaign_id=None, tags=None):
# sanity checks``````
Found in mailgun2/mailgun.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Cyclomatic complexity is too high in method add_list_member. (6) Open

``````    def add_list_member(self, list_name, address, name=None, params=None,
subscribed=True, upsert=False):
if name:
data['name'] = name``````

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Cyclomatic complexity is too high in method get_events. (6) Open

``````    def get_events(self, begin=None, end=None, ascending=None, limit=None,
filters=None):
params = {}

if begin:``````

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Function `send_message` has 14 arguments (exceeds 4 allowed). Consider refactoring. Open

``    def send_message(self, from_email, to, cc=None, bcc=None,``
Found in mailgun2/mailgun.py - About 1 hr to fix

Function `add_list_member` has 6 arguments (exceeds 4 allowed). Consider refactoring. Open

``    def add_list_member(self, list_name, address, name=None, params=None,``
Found in mailgun2/mailgun.py - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring. Open

``````        if user_variables:
for k, v in user_variables.items():
data['v:%s' % k] = v``````
Found in mailgun2/mailgun.py and 1 other location - About 40 mins to fix
mailgun2/mailgun.py on lines 58..60

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

Refactorings

Similar blocks of code found in 2 locations. Consider refactoring. Open

``````        if headers:
data["h:%s" % k] = v``````
Found in mailgun2/mailgun.py and 1 other location - About 40 mins to fix
mailgun2/mailgun.py on lines 68..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 34.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See `codeclimate-duplication`'s documentation for more information about tuning the mass threshold in your `.codeclimate.yml`.

Refactorings

Function `post` has 5 arguments (exceeds 4 allowed). Consider refactoring. Open

``    def post(self, path, data, files=None, include_domain=True, auth=None):``
Found in mailgun2/mailgun.py - About 35 mins to fix

Function `get_events` has 5 arguments (exceeds 4 allowed). Consider refactoring. Open

``    def get_events(self, begin=None, end=None, ascending=None, limit=None,``
Found in mailgun2/mailgun.py - About 35 mins to fix

Function `add_list_member` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

``````    def add_list_member(self, list_name, address, name=None, params=None,
subscribed=True, upsert=False):
if name:
data['name'] = name``````
Found in mailgun2/mailgun.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

Do not use bare except' Open

``except:``
Found in mailgun2/__init__.py by pep8

When catching exceptions, mention specific exceptions whenever possible.

``````Okay: except Exception:
Okay: except BaseException:
E722: except:``````

Line too long (92 > 79 characters) Open

``        return self.get('/address/validate', params=params, auth=auth, include_domain=False)``
Found in mailgun2/mailgun.py by pep8

Limit all lines to a maximum of 79 characters.

``````There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to have
several windows side-by-side.  The default wrapping on such devices looks
ugly.  Therefore, please limit all lines to a maximum of 79 characters.
For flowing long blocks of text (docstrings or comments), limiting the
length to 72 characters is recommended.

Reports error E501.``````