Sign upLogin

alexandre-normand/slackscot

View on GitHub
Star

Showing 4 of 31 total issues

Slackscot has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

type Slackscot struct {
    name                    string
    config                  *viper.Viper
    defaultAction           Answerer
    plugins                 []*Plugin
Severity: Minor
Found in slackscot.go - About 2 hrs to fix

    Function newInstrumenter has 6 return statements (exceeds 4 allowed).
    Open

    func newInstrumenter(appName string, meter metric.Meter, latencyCallback metric.Int64ObserverFunc) (ins *instrumenter, err error) {
    ins = new(instrumenter)

    defaultLabels := []label.KeyValue{label.String("name", appName)}
    Severity: Major
    Found in coremetrics.go - About 40 mins to fix

      Method Karma.recordKarma has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

      func (k *Karma) recordKarma(message *slackscot.IncomingMessage) *slackscot.Answer {
    matches := karmaRegex.FindAllStringSubmatch(message.Text, -1)
    answerText := ""
    
    for idx, match := range matches {
      Severity: Minor
      Found in plugins/karma.go - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function New has 5 return statements (exceeds 4 allowed).
      Open

      func New(name string, v *viper.Viper, options ...Option) (s *Slackscot, err error) {
    s = new(Slackscot)

    s.triggeringMsgToResponse, err = lru.NewARC(v.GetInt(config.ResponseCacheSizeKey))
    if err != nil {
      Severity: Major
      Found in slackscot.go - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language