alexreisner/geocoder

View on GitHub
lib/geocoder/stores/active_record.rb

Summary

Maintainability
C
1 day
Test Coverage

Method near_scope_options has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

      def near_scope_options(latitude, longitude, radius = 20, options = {})
        if options[:units]
          options[:units] = options[:units].to_sym
        end
        latitude_attribute = options[:latitude] || geocoder_options[:latitude]
Severity: Minor
Found in lib/geocoder/stores/active_record.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method near_scope_options has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def near_scope_options(latitude, longitude, radius = 20, options = {})
        if options[:units]
          options[:units] = options[:units].to_sym
        end
        latitude_attribute = options[:latitude] || geocoder_options[:latitude]
Severity: Minor
Found in lib/geocoder/stores/active_record.rb - About 1 hr to fix

    Method included has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def self.included(base)
          base.extend ClassMethods
          base.class_eval do
    
            # scope: geocoded objects
    Severity: Minor
    Found in lib/geocoder/stores/active_record.rb - About 1 hr to fix

      Method included has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.included(base)
            base.extend ClassMethods
            base.class_eval do
      
              # scope: geocoded objects
      Severity: Minor
      Found in lib/geocoder/stores/active_record.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method select_clause has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def select_clause(columns, distance = nil, bearing = nil, distance_column = 'distance', bearing_column = 'bearing')
              if columns == :id_only
                return full_column_name(primary_key)
              elsif columns == :geo_only
                clause = ""
      Severity: Minor
      Found in lib/geocoder/stores/active_record.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method select_clause has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def select_clause(columns, distance = nil, bearing = nil, distance_column = 'distance', bearing_column = 'bearing')
      Severity: Minor
      Found in lib/geocoder/stores/active_record.rb - About 35 mins to fix

        Method geocode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def geocode
              do_lookup(false) do |o,rs|
                if r = rs.first
                  unless r.latitude.nil? or r.longitude.nil?
                    o.__send__  "#{self.class.geocoder_options[:latitude]}=",  r.latitude
        Severity: Minor
        Found in lib/geocoder/stores/active_record.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method bearing_sql has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def bearing_sql(latitude, longitude, options = {})
                if !options.include?(:bearing)
                  options[:bearing] = Geocoder.config.distances
                end
                if options[:bearing]
        Severity: Minor
        Found in lib/geocoder/stores/active_record.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method reverse_geocode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def reverse_geocode
              do_lookup(true) do |o,rs|
                if r = rs.first
                  unless r.address.nil?
                    o.__send__ "#{self.class.geocoder_options[:fetched_address]}=", r.address
        Severity: Minor
        Found in lib/geocoder/stores/active_record.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            def reverse_geocode
              do_lookup(true) do |o,rs|
                if r = rs.first
                  unless r.address.nil?
                    o.__send__ "#{self.class.geocoder_options[:fetched_address]}=", r.address
        Severity: Minor
        Found in lib/geocoder/stores/active_record.rb and 1 other location - About 25 mins to fix
        lib/geocoder/stores/mongo_base.rb on lines 46..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                Geocoder::Sql.send(
                  method_prefix + "_distance",
                  latitude, longitude,
                  full_column_name(options[:latitude] || geocoder_options[:latitude]),
                  full_column_name(options[:longitude]|| geocoder_options[:longitude]),
        Severity: Minor
        Found in lib/geocoder/stores/active_record.rb and 1 other location - About 15 mins to fix
        lib/geocoder/stores/active_record.rb on lines 194..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  Geocoder::Sql.send(
                    method_prefix + "_bearing",
                    latitude, longitude,
                    full_column_name(options[:latitude] || geocoder_options[:latitude]),
                    full_column_name(options[:longitude]|| geocoder_options[:longitude]),
        Severity: Minor
        Found in lib/geocoder/stores/active_record.rb and 1 other location - About 15 mins to fix
        lib/geocoder/stores/active_record.rb on lines 175..180

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status