alsemyonov/ymaps

View on GitHub

Showing 5 of 7 total issues

Method style_options has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

      def style_options(options = {}, acceptable = nil)
        if acceptable
          options.assert_valid_keys(acceptable)
        end
        # Filling options
Severity: Minor
Found in lib/ymaps/action_view/ymapsml_helper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method static_map has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def static_map(resources, options = {})
        title = options.delete(:title) { resources.to_s }
        map_type = options.delete(:map) { 'map' }
        width = options.delete(:width) { 600 }
        height = options.delete(:height) { 450 }
Severity: Minor
Found in lib/ymaps/action_view/html_helper.rb - About 1 hr to fix

    Method object has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def object(object, options = {})
            gml_id = options.delete(:id) { object.id }
            GeoObject('gml:id' => gml_id) do
              if options.key?(:style)
                @xml.style("\##{options.delete(:style)}")
    Severity: Minor
    Found in lib/ymaps/action_view/ymapsml_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method view has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def view(options = {})
            View {
              mapType(options[:type].to_s.upcase) if options[:type]
              bounds(options[:bounds]) if options[:bounds]
              yield if block_given?
    Severity: Minor
    Found in lib/ymaps/action_view/ymapsml_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method xml2GeoLoc has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.xml2GeoLoc(xml, address="")
            doc = REXML::Document.new(xml)
    
            if doc.elements['//GeocoderResponseMetaData/found'] != '0'
              geoloc = nil
    Severity: Minor
    Found in lib/geokit/geocoders/yandex_geocoder.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language