Sign upLogin

alvinsj/flatten_record

View on GitHub
Star

Showing 7 of 9 total issues

Class NormalizedAttr has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

    class NormalizedAttr < Node
      
      def denormalize(instance, to_record)
        denormalize_children(instance, to_record)
      end
Severity: Minor
Found in lib/flatten_record/meta/normalized_attr.rb - About 2 hrs to fix

    Class MigrationGenerator has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class MigrationGenerator < ActiveRecord::Generators::Base
      def self.source_root
        @source_root ||= File.join(File.dirname(__FILE__), 'templates')
      end
    Severity: Minor
    Found in lib/generators/flatten_record/migration/migration_generator.rb - About 2 hrs to fix

      Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def initialize(parent, method, type, target_model, model, options={})
      Severity: Minor
      Found in lib/flatten_record/meta/method_column.rb - About 45 mins to fix

        Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def initialize(parent, method, type, target_model, model, options={})
        Severity: Minor
        Found in lib/flatten_record/meta/compute_column.rb - About 45 mins to fix

          Method traverse_by has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def traverse_by(attr, value)
        attr_value = send("#{attr}")

        if !value.respond_to?(:to_s) || !attr_value.respond_to?(:to_s)
          raise "traverse error: to_s method required for comparison"
          Severity: Minor
          Found in lib/flatten_record/meta/normalized_attr.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method diff_and_generate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def diff_and_generate
        if any_diff?
          puts "Generating migration based on the difference.."
          puts "  #{yellow('Other columns(not defined):')} #{extra_columns_names}" unless extra_columns.empty?
          puts "  #{green('Add columns:')} #{add_columns_names}" unless add_columns.empty?
          Severity: Minor
          Found in lib/generators/flatten_record/migration/migration_generator.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create_with has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def create_with(normal)
        if normal_model.eql?(normal.class)
          destroy_with(normal)
          records = flattener_meta.denormalize(normal.reload, self.new)
          records.respond_to?(:each) ? records.each(&:save) : records.save
          Severity: Minor
          Found in lib/flatten_record/flattener.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language