Sign upLogin

ama-team/php-projection-framework

View on GitHub
Star

Showing 102 of 102 total issues

Method process has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function process(TileInterface $tile, SpecificationInterface $specification)
    {
        $image = $tile->getImage();
        $width = $image->getWidth();
        $height = $image->getHeight();
Severity: Major
Found in src/Conversion/Processor/FXAAProcessor.php - About 2 hrs to fix

    Function calculate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function calculate(Edge $edge, $inverse = false)
    {
        $width = $edge->image->getWidth();
        $height = $edge->image->getHeight();
        $offset = $inverse ? -1 : 1;
    Severity: Minor
    Found in src/Conversion/Processor/FXAA/EdgeDistanceCalculator.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method calculate has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function calculate(Edge $edge, $inverse = false)
    {
        $width = $edge->image->getWidth();
        $height = $edge->image->getHeight();
        $offset = $inverse ? -1 : 1;
    Severity: Minor
    Found in src/Conversion/Processor/FXAA/EdgeDistanceCalculator.php - About 1 hr to fix

      Function process has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function process(TileInterface $tile, SpecificationInterface $specification)
    {
        $image = $tile->getImage();
        $width = $image->getWidth();
        $height = $image->getHeight();
      Severity: Minor
      Found in src/Conversion/Processor/FXAAProcessor.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getColorsAt has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getColorsAt($face, $u, $v)
    {
        $colors = [];
        $normalizedU = $u * $this->width - 0.5;
        $normalizedV = $v * $this->height - 0.5;
      Severity: Minor
      Found in src/Type/BilinearReader.php - About 1 hr to fix

        Method validate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function validate($value, array $path = [])
    {
        if (!is_array($value)) {
            throw new ValidationException('Is empty', $path);
        }
        Severity: Minor
        Found in src/Framework/Validation/Tile/TileTreeValidator.php - About 1 hr to fix

          Function validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function validate($value, array $path = [])
    {
        if (!is_array($value)) {
            throw new ValidationException('Is empty', $path);
        }
          Severity: Minor
          Found in src/Framework/Validation/Tile/TileTreeValidator.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $x. Configured minimum length is 3.
          Open

              public function setColorAt($x, $y, $color)
          Severity: Minor
          Found in src/Image/Adapter/Gd/Image.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $y. Configured minimum length is 3.
          Open

                  $y = sin($longitude) * $xyHypotenuse;
          Severity: Minor
          Found in src/Type/CubeMap/Mapping/Vector.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $x. Configured minimum length is 3.
          Open

                  $x = (int) min(0.5 + ($tileU * $this->tileWidth), $this->tileWidth - 1);
          Severity: Minor
          Found in src/Type/NearestNeighbourReader.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $y. Configured minimum length is 3.
          Open

                  $y = (int) min(0.5 + ($tileV * $this->tileHeight), $this->tileHeight - 1);
          Severity: Minor
          Found in src/Type/NearestNeighbourReader.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $x. Configured minimum length is 3.
          Open

              public function getColorAt($x, $y)
          Severity: Minor
          Found in src/Image/Adapter/Imagick/Image.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $x. Configured minimum length is 3.
          Open

              public function __construct($face, $x, $y)
          Severity: Minor
          Found in src/Tile/Position.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $u. Configured minimum length is 3.
          Open

                          $u = $uOffset + $x * $uStep;
          Severity: Minor
          Found in src/Type/DefaultGenerator.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $v. Configured minimum length is 3.
          Open

              public function getCoordinates($face, $u, $v);
          Severity: Minor
          Found in src/API/Type/MappingInterface.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $u. Configured minimum length is 3.
          Open

                  $u = 0.5 + ($vector[$this->uMapping[0]] * $this->uMapping[1] / 2);
          Severity: Minor
          Found in src/Type/CubeMap/Mapping/Face.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $y. Configured minimum length is 3.
          Open

              public static function fromCartesian($x, $y, $z)
          Severity: Minor
          Found in src/Type/CubeMap/Mapping/Vector.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $v. Configured minimum length is 3.
          Open

                  $v = $position[2] / $this->columnSize;
          Severity: Minor
          Found in src/Type/NearestNeighbourReader.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $y. Configured minimum length is 3.
          Open

              public function getColorAt($x, $y);
          Severity: Minor
          Found in src/API/Image/ImageInterface.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Avoid variables with short names like $y. Configured minimum length is 3.
          Open

              public function fill(ImageInterface $image, $x, $y)
          Severity: Minor
          Found in src/Conversion/Processor/FXAA/ColorGrid.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          Severity
          Category
          Status
          Source
          Language