Sign upLogin

amahi/platform

View on GitHub
Star
app/controllers/aliases_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method valid_address? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_address?(addr)
        return false if addr.nil?
        # NOTE: do not allow aliases to the hda as a blank address
        return false if addr.blank?
        return false unless (addr =~ VALID_ADDRESS)
Severity: Minor
Found in app/controllers/aliases_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_address has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def update_address
        a = DnsAlias.find(params[:id])
        addr = params[:value].strip
        # FIXME - report errors to the user!
        unless valid_address?(addr)
Severity: Minor
Found in app/controllers/aliases_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return true
Severity: Major
Found in app/controllers/aliases_controller.rb - About 30 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def new_alias_check
        n = params[:alias]
        if n.nil? or n.blank?
            render :partial => 'aliases/name_bad'
            return
    Severity: Major
    Found in app/controllers/aliases_controller.rb and 1 other location - About 1 hr to fix
    app/controllers/hosts_controller.rb on lines 164..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def delete
        a = DnsAlias.find params[:id]
        a.destroy
        aliases = DnsAlias.user_visible
        @net = Setting.get('net')
    Severity: Minor
    Found in app/controllers/aliases_controller.rb and 1 other location - About 40 mins to fix
    app/controllers/hosts_controller.rb on lines 153..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status