Sign upLogin

amahi/platform

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class ApplicationController has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
    require 'ipaddr'
    protect_from_forgery with: :exception

    before_action :before_action_hook
Severity: Minor
Found in app/controllers/application_controller.rb - About 2 hrs to fix

    Method set_locale has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def set_locale

        preferred_locales = request.headers['HTTP_ACCEPT_LANGUAGE'].split(',').map { |locale| locale.split(';').first } rescue nil
        available_locales = I18n.available_locales
        default_locale = I18n.default_locale
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setup_router has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def setup_router
        @router = nil
        r = Setting.get_kind('network', 'router_model')
        return @router unless r
        begin
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status