amahi/platform

View on GitHub
lib/platform.rb

Summary

Maintainability
D
3 days
Test Coverage

File platform.rb has 374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'downloader'

class Platform

    # upstart conf file for an ubuntu system
Severity: Minor
Found in lib/platform.rb - About 5 hrs to fix

    Method set_platform has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

            def set_platform
                if File.exist?('/etc/amahi-release')
                    line = nil
                    File.open("/etc/amahi-release", "r") do |issue|
                        line = issue.gets
    Severity: Minor
    Found in lib/platform.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Platform has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Platform
    
        # upstart conf file for an ubuntu system
        UPSTART_CONF = "/etc/init/%s.conf"
    
    
    Severity: Minor
    Found in lib/platform.rb - About 3 hrs to fix

      Method platform_versions has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
      Open

              def platform_versions
                  platform = ""
                  hda_ctl = ""
                  if fedora? or centos?
                      open("|rpm -q hda-platform hda-ctl") do |f|
      Severity: Minor
      Found in lib/platform.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method platform_versions has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              def platform_versions
                  platform = ""
                  hda_ctl = ""
                  if fedora? or centos?
                      open("|rpm -q hda-platform hda-ctl") do |f|
      Severity: Minor
      Found in lib/platform.rb - About 1 hr to fix

        Method set_platform has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                def set_platform
                    if File.exist?('/etc/amahi-release')
                        line = nil
                        File.open("/etc/amahi-release", "r") do |issue|
                            line = issue.gets
        Severity: Minor
        Found in lib/platform.rb - About 1 hr to fix

          Method pkguninstall has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                  def pkguninstall(pkgs)
                      if debian? or ubuntu? or mint?
                          c = Command.new "DEBIAN_FRONTEND=noninteractive apt-get -y remove #{pkgs}"
                          c.run_now
                      elsif fedora? or centos?
          Severity: Minor
          Found in lib/platform.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method pkginstall has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

                  def pkginstall(pkgs, sha1 = nil)
                      if debian? or ubuntu? or mint?
                          c = Command.new "DEBIAN_FRONTEND=noninteractive apt-get -y install #{pkgs}"
                          c.run_now
                      elsif fedora? or centos?
          Severity: Minor
          Found in lib/platform.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method service_disable_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def service_disable_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl enable #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Minor
          Found in lib/platform.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method service_start_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def service_start_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl start #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Minor
          Found in lib/platform.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method service_enable_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def service_enable_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl enable #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Minor
          Found in lib/platform.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method service_stop_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                  def service_stop_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl stop #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Minor
          Found in lib/platform.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def service_enable_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl enable #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Major
          Found in lib/platform.rb and 3 other locations - About 45 mins to fix
          lib/platform.rb on lines 225..235
          lib/platform.rb on lines 238..248
          lib/platform.rb on lines 264..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def service_start_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl start #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Major
          Found in lib/platform.rb and 3 other locations - About 45 mins to fix
          lib/platform.rb on lines 238..248
          lib/platform.rb on lines 251..261
          lib/platform.rb on lines 264..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def service_stop_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl stop #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Major
          Found in lib/platform.rb and 3 other locations - About 45 mins to fix
          lib/platform.rb on lines 225..235
          lib/platform.rb on lines 251..261
          lib/platform.rb on lines 264..274

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  def service_disable_command(name)
                      service = service_name(name)
                      if fedora? or arch? or centos?
                          "/usr/bin/systemctl enable #{service}.service"
                      elsif ubuntu? and File.exist?(UPSTART_CONF % service)
          Severity: Major
          Found in lib/platform.rb and 3 other locations - About 45 mins to fix
          lib/platform.rb on lines 225..235
          lib/platform.rb on lines 238..248
          lib/platform.rb on lines 251..261

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 40.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status