andela-iadeniyi/Potato-ORM

View on GitHub

Showing 14 of 14 total issues

DatabaseQuery has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class DatabaseQuery implements DatabaseQueryInterface
{
    //Inject the inflector trait, file upload trait
    use Inflector, Upload;

Severity: Minor
Found in src/Database/DatabaseQuery.php - About 2 hrs to fix

    Method singularize has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function singularize($word)
        {
            $singular = array (
                '/(quiz)zes$/i'             => "$1",
                '/(matr)ices$/i'            => "$1ix",
    Severity: Major
    Found in src/Helper/Inflector.php - About 2 hrs to fix

      Method pluralize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function pluralize($word)
          {
              $plural = array(
                  '/(quiz)$/i'               => "$1zes",
                  '/^(ox)$/i'                => "$1en",
      Severity: Minor
      Found in src/Helper/Inflector.php - About 1 hr to fix

        Function joinClause has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function joinClause($con = null)
            {
                $connection = self::checkConnection($con);
        
                $data = self::query('SELECT COLUMN_NAME, REFERENCED_TABLE_NAME, REFERENCED_COLUMN_NAME FROM INFORMATION_SCHEMA.KEY_COLUMN_USAGE WHERE TABLE_NAME="'.self::getTableName($connection).'"')->all();
        Severity: Minor
        Found in src/Helper/Relationships.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ($irregular as $_plural=> $_singular){
                    if (preg_match('/('.$_singular.')$/i', $word, $arr)) {
                        return preg_replace('/('.$_singular.')$/i', substr($arr[0],0,1).substr($_plural,1), $word);
                    }
                }
        Severity: Major
        Found in src/Helper/Inflector.php and 1 other location - About 1 hr to fix
        src/Helper/Inflector.php on lines 90..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ($irregular as $_plural=> $_singular){
                    if (preg_match('/('.$_plural.')$/i', $word, $arr)) {
                        return preg_replace('/('.$_plural.')$/i', substr($arr[0],0,1).substr($_singular,1), $word);
                    }
                }
        Severity: Major
        Found in src/Helper/Inflector.php and 1 other location - About 1 hr to fix
        src/Helper/Inflector.php on lines 161..165

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 89.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function pluralize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function pluralize($word)
            {
                $plural = array(
                    '/(quiz)$/i'               => "$1zes",
                    '/^(ox)$/i'                => "$1en",
        Severity: Minor
        Found in src/Helper/Inflector.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function singularize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function singularize($word)
            {
                $singular = array (
                    '/(quiz)zes$/i'             => "$1",
                    '/(matr)ices$/i'            => "$1ix",
        Severity: Minor
        Found in src/Helper/Inflector.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function selectQuery has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function selectQuery($tableName, $fields, $data, $condition, $connection)
            {
                $query = "";
                $columnName = "";
                
        Severity: Minor
        Found in src/Database/DatabaseQuery.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method selectQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static function selectQuery($tableName, $fields, $data, $condition, $connection);
        Severity: Minor
        Found in src/Interface/DatabaseQueryInterface.php - About 35 mins to fix

          Method selectQuery has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static function selectQuery($tableName, $fields, $data, $condition, $connection)
          Severity: Minor
          Found in src/Database/DatabaseQuery.php - About 35 mins to fix

            Function whereAndClause has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function whereAndClause($tableName, $data, $condition)
                {
                    $where = "";
                    $counter = 0;
                    $arraySize = count($data);
            Severity: Minor
            Found in src/Database/DatabaseQuery.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function dateTime has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function dateTime($value, $type = NULL)
                {
                    $apend = "";
                    switch ($type) {
                        case 'time':
            Severity: Minor
            Found in src/Helper/Schema.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function whereClause has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function whereClause($data = null, $condition = null, $con = null)
                {
                    $joinClause = self::joinClause();
                    $connection = self::checkConnection($con);
                    $tableName  = self::getTableName($connection);
            Severity: Minor
            Found in src/Helper/Relationships.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language