andersondanilo/CnabPHP

View on GitHub
src/Cnab/Remessa/Cnab400/Arquivo.php

Summary

Maintainability
D
2 days
Test Coverage
F
0%

Method insertDetalhe has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function insertDetalhe(array $boleto, $tipo = 'remessa')
    {
        $dateVencimento = $boleto['data_vencimento'] instanceof \DateTime ? $boleto['data_vencimento'] : new \DateTime($boleto['data_vencimento']);
        $dateCadastro = $boleto['data_cadastro']   instanceof \DateTime ? $boleto['data_cadastro']   : new \DateTime($boleto['data_cadastro']);

Severity: Major
Found in src/Cnab/Remessa/Cnab400/Arquivo.php - About 4 hrs to fix

    Function insertDetalhe has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        public function insertDetalhe(array $boleto, $tipo = 'remessa')
        {
            $dateVencimento = $boleto['data_vencimento'] instanceof \DateTime ? $boleto['data_vencimento'] : new \DateTime($boleto['data_vencimento']);
            $dateCadastro = $boleto['data_cadastro']   instanceof \DateTime ? $boleto['data_cadastro']   : new \DateTime($boleto['data_cadastro']);
    
    
    Severity: Minor
    Found in src/Cnab/Remessa/Cnab400/Arquivo.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File Arquivo.php has 294 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace Cnab\Remessa\Cnab400;
    
    class Arquivo implements \Cnab\Remessa\IArquivo
    Severity: Minor
    Found in src/Cnab/Remessa/Cnab400/Arquivo.php - About 3 hrs to fix

      Method configure has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function configure(array $params)
          {
              $campos = array(
                  'data_geracao', 'data_gravacao', 'nome_fantasia', 'razao_social', 'cnpj', 'logradouro', 'numero', 'bairro',
                  'cidade', 'uf', 'cep', 'agencia', 'conta'
      Severity: Major
      Found in src/Cnab/Remessa/Cnab400/Arquivo.php - About 2 hrs to fix

        Function configure has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            public function configure(array $params)
            {
                $campos = array(
                    'data_geracao', 'data_gravacao', 'nome_fantasia', 'razao_social', 'cnpj', 'logradouro', 'numero', 'bairro',
                    'cidade', 'uf', 'cep', 'agencia', 'conta'
        Severity: Minor
        Found in src/Cnab/Remessa/Cnab400/Arquivo.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                foreach ($campos as $campo) {
                    if (array_key_exists($campo, $params)) {
                        if (strpos($campo, 'data_') === 0 && !($params[$campo] instanceof \DateTime)) {
                            throw new \Exception("config '$campo' need to be instance of DateTime");
                        }
        Severity: Major
        Found in src/Cnab/Remessa/Cnab400/Arquivo.php and 1 other location - About 1 hr to fix
        src/Cnab/Remessa/Cnab240/Arquivo.php on lines 58..67

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status