andresvillenas/Sitecore.Extensions

View on GitHub
Sitecore.Extensions/sitecore/shell/Applications/Extensions/JumpList.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function onJumpListClick has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

scContentEditor.prototype.onJumpListClick = function (sender, evt) {
    var ctl = scForm.browser.getSrcElement(evt);

    if (ctl != null) {
        if (ctl.id != null && ctl.id.indexOf("_Glyph_") >= 0) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onJumpListClick has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

scContentEditor.prototype.onJumpListClick = function (sender, evt) {
    var ctl = scForm.browser.getSrcElement(evt);

    if (ctl != null) {
        if (ctl.id != null && ctl.id.indexOf("_Glyph_") >= 0) {

    Avoid too many return statements within this function.
    Open

        return false;
    Severity: Major
    Found in Sitecore.Extensions/sitecore/shell/Applications/Extensions/JumpList.js - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status