andresvillenas/Sitecore.Extensions

View on GitHub

Showing 9 of 11 total issues

Function onJumpListClick has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

scContentEditor.prototype.onJumpListClick = function (sender, evt) {
    var ctl = scForm.browser.getSrcElement(evt);

    if (ctl != null) {
        if (ctl.id != null && ctl.id.indexOf("_Glyph_") >= 0) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public override CommandState QueryState(CommandContext context)
        {
            if (!context.IsContextMenu)
                return CommandState.Hidden;

Sitecore.Extensions/ContentEditor/ContentTree/JumpList/Commands/RemoveFromJumpList.cs on lines 21..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public override CommandState QueryState(CommandContext context)
        {
            if (!context.IsContextMenu)
                return CommandState.Hidden;

Sitecore.Extensions/ContentEditor/ContentTree/JumpList/Commands/AddToJumpList.cs on lines 23..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 155.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method RenderPinItem has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private void RenderPinItem(HtmlTextWriter output, Item item, string inner)
        {
            Assert.ArgumentNotNull(output, nameof(output));
            Assert.ArgumentNotNull(item, nameof(item));
            Assert.ArgumentNotNull(inner, nameof(inner));
Severity: Minor
Found in Sitecore.Extensions/ContentEditor/ContentTree/JumpList/JumpList.cs - About 1 hr to fix

    Function onJumpListClick has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    scContentEditor.prototype.onJumpListClick = function (sender, evt) {
        var ctl = scForm.browser.getSrcElement(evt);
    
        if (ctl != null) {
            if (ctl.id != null && ctl.id.indexOf("_Glyph_") >= 0) {

      Method CreateJumpListForUser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              private Item CreateJumpListForUser(User user)
              {
                  using (new SecurityDisabler())
                  {
                      try

        Avoid too many return statements within this method.
        Open

                        return CommandState.Hidden;

          Avoid too many return statements within this method.
          Open

                          return CommandState.Hidden;

            Avoid too many return statements within this function.
            Open

                return false;
            Severity: Major
            Found in Sitecore.Extensions/sitecore/shell/Applications/Extensions/JumpList.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language