anthonymidili/FishBowl

View on GitHub

Showing 4 of 4 total issues

Method nitrate_level has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def nitrate_level(level)
    if @bowl.water_type == 'Freshwater'
      case level
        when nil
          level_nil
Severity: Minor
Found in app/helpers/test_results_helper.rb - About 1 hr to fix

    Method ph_level has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def ph_level(level)
        if @bowl.water_type == 'Freshwater'
          case level
            when nil
              level_nil
    Severity: Minor
    Found in app/helpers/test_results_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method nitrate_level has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def nitrate_level(level)
        if @bowl.water_type == 'Freshwater'
          case level
            when nil
              level_nil
    Severity: Minor
    Found in app/helpers/test_results_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method alkalinity_level has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def alkalinity_level(level)
        if @bowl.water_type == 'Freshwater'
          case level
            when nil
              level_nil
    Severity: Minor
    Found in app/helpers/test_results_helper.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language