Sign upLogin

apex/up

View on GitHub
Star
internal/cli/team/team.go

Summary

Maintainability
D
2 days
Test Coverage

File team.go has 561 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package team

import (
    "context"
    "encoding/base64"
Severity: Minor
Found in internal/cli/team/team.go - About 3 hrs to fix

    Function subscribe has 83 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func subscribe(cmd *kingpin.Cmd) {
    c := cmd.Command("subscribe", "Subscribe to the Pro plan.")

    c.Action(func(_ *kingpin.ParseContext) error {
        t, err := userconfig.Require()
    Severity: Major
    Found in internal/cli/team/team.go - About 2 hrs to fix

      Function login has 78 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func login(cmd *kingpin.Cmd) {
    c := cmd.Command("login", "Sign in to your account.")
    c.Example(`up team login`, "Sign in or create account with interactive prompt.")
    c.Example(`up team login --team apex-software`, "Sign in to a team using your existing email.")
    c.Example(`up team login --email tj@example.com --team apex-software`, "Sign in to a team with email.")
      Severity: Major
      Found in internal/cli/team/team.go - About 2 hrs to fix

        Function login has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
        Open

        func login(cmd *kingpin.Cmd) {
    c := cmd.Command("login", "Sign in to your account.")
    c.Example(`up team login`, "Sign in or create account with interactive prompt.")
    c.Example(`up team login --team apex-software`, "Sign in to a team using your existing email.")
    c.Example(`up team login --email tj@example.com --team apex-software`, "Sign in to a team with email.")
        Severity: Minor
        Found in internal/cli/team/team.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function subscribe has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
        Open

        func subscribe(cmd *kingpin.Cmd) {
    c := cmd.Command("subscribe", "Subscribe to the Pro plan.")

    c.Action(func(_ *kingpin.ParseContext) error {
        t, err := userconfig.Require()
        Severity: Minor
        Found in internal/cli/team/team.go - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function subscribe has 10 return statements (exceeds 4 allowed).
        Open

        func subscribe(cmd *kingpin.Cmd) {
    c := cmd.Command("subscribe", "Subscribe to the Pro plan.")

    c.Action(func(_ *kingpin.ParseContext) error {
        t, err := userconfig.Require()
        Severity: Major
        Found in internal/cli/team/team.go - About 1 hr to fix

          Function login has 7 return statements (exceeds 4 allowed).
          Open

          func login(cmd *kingpin.Cmd) {
    c := cmd.Command("login", "Sign in to your account.")
    c.Example(`up team login`, "Sign in or create account with interactive prompt.")
    c.Example(`up team login --team apex-software`, "Sign in to a team using your existing email.")
    c.Example(`up team login --email tj@example.com --team apex-software`, "Sign in to a team with email.")
          Severity: Major
          Found in internal/cli/team/team.go - About 45 mins to fix

            Function add has 7 return statements (exceeds 4 allowed).
            Open

            func add(cmd *kingpin.Cmd) {
    c := cmd.Command("add", "Add a new team.")
    name := c.Arg("name", "Name of the team.").Required().String()

    c.Action(func(_ *kingpin.ParseContext) error {
            Severity: Major
            Found in internal/cli/team/team.go - About 45 mins to fix

              Function status has 6 return statements (exceeds 4 allowed).
              Open

              func status(cmd *kingpin.Cmd) {
    c := cmd.Command("status", "Status of your account.").Default()

    c.Action(func(_ *kingpin.ParseContext) error {
        var config userconfig.Config
              Severity: Major
              Found in internal/cli/team/team.go - About 40 mins to fix

                Function unsubscribe has 6 return statements (exceeds 4 allowed).
                Open

                func unsubscribe(cmd *kingpin.Cmd) {
    c := cmd.Command("unsubscribe", "Unsubscribe from the Pro plan.")

    c.Action(func(_ *kingpin.ParseContext) error {
        config, err := userconfig.Require()
                Severity: Major
                Found in internal/cli/team/team.go - About 40 mins to fix

                  Function changeCard has 5 return statements (exceeds 4 allowed).
                  Open

                  func changeCard(cmd *kingpin.Cmd) {
    c := cmd.Command("change", "Change the default card.")

    c.Action(func(_ *kingpin.ParseContext) error {
        t, err := userconfig.Require()
                  Severity: Major
                  Found in internal/cli/team/team.go - About 35 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        c.Action(func(_ *kingpin.ParseContext) error {
        t, err := userconfig.Require()
        if err != nil {
            return err
        }
                    Severity: Major
                    Found in internal/cli/team/team.go and 1 other location - About 1 hr to fix
                    internal/cli/team/team.go on lines 618..636

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 163.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        c.Action(func(_ *kingpin.ParseContext) error {
        t, err := userconfig.Require()
        if err != nil {
            return err
        }
                    Severity: Major
                    Found in internal/cli/team/team.go and 1 other location - About 1 hr to fix
                    internal/cli/team/team.go on lines 591..609

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 163.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status