appirits/comable

View on GitHub

Showing 23 of 34 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def change
    create_table :comable_shipments do |t|
      t.references :order, null: false
      t.references :shipment_method, null: false
      t.integer :fee, null: false
Severity: Minor
Found in core/db/migrate/20150423095210_create_comable_shipments.rb and 1 other location - About 50 mins to fix
core/db/migrate/20140817194104_create_comable_payment_methods.rb on lines 2..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def change
    create_table :comable_payment_methods do |t|
      t.string :name, null: false
      t.string :payment_provider_type, null: false
      t.integer :payment_provider_kind, null: false
core/db/migrate/20150423095210_create_comable_shipments.rb on lines 2..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Comable::Address.create!(
  family_name: Comable::Sample::Name.family_name,
  first_name: Comable::Sample::Name.first_name,
  zip_code: Comable::Sample::Address.zip_code,
  state_name: Comable::Sample::Address.state_name,
Severity: Minor
Found in sample/db/samples/addresses.rb and 1 other location - About 45 mins to fix
sample/db/samples/addresses.rb on lines 13..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Comable::Address.create!(
  family_name: Comable::Sample::Name.family_name,
  first_name: Comable::Sample::Name.first_name,
  zip_code: Comable::Sample::Address.zip_code,
  state_name: Comable::Sample::Address.state_name,
Severity: Minor
Found in sample/db/samples/addresses.rb and 1 other location - About 45 mins to fix
sample/db/samples/addresses.rb on lines 2..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def import
        ActiveRecord::Base.transaction do
          Comable::Stock.import_from(params[:file])
        end
        redirect_to comable.admin_stocks_path, notice: Comable.t('successful')
Severity: Minor
Found in backend/app/controllers/comable/admin/stocks_controller.rb and 1 other location - About 35 mins to fix
backend/app/controllers/comable/admin/products_controller.rb on lines 61..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def import
        ActiveRecord::Base.transaction do
          Comable::Product.import_from(params[:file])
        end
        redirect_to comable.admin_products_path, notice: Comable.t('successful')
Severity: Minor
Found in backend/app/controllers/comable/admin/products_controller.rb and 1 other location - About 35 mins to fix
backend/app/controllers/comable/admin/stocks_controller.rb on lines 63..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  {
    product: girly_coat,
    options: [name: Comable::Sample.t(:size), value: 'M'] + [name: Comable::Sample.t(:color), value: Comable::Sample.t(:navy)],
    stocks_attributes: [default_stock_attributes],
    sku: 'GIRLY-COAT-MN'
Severity: Major
Found in sample/db/samples/variants.rb and 5 other locations - About 25 mins to fix
sample/db/samples/variants.rb on lines 13..18
sample/db/samples/variants.rb on lines 19..24
sample/db/samples/variants.rb on lines 25..30
sample/db/samples/variants.rb on lines 31..36
sample/db/samples/variants.rb on lines 37..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  {
    product: suede_dress,
    options: [name: Comable::Sample.t(:size), value: 'M'] + [name: Comable::Sample.t(:color), value: Comable::Sample.t(:navy)],
    stocks_attributes: [default_stock_attributes],
    sku: 'SUEDE-DRESS-MN'
Severity: Major
Found in sample/db/samples/variants.rb and 5 other locations - About 25 mins to fix
sample/db/samples/variants.rb on lines 13..18
sample/db/samples/variants.rb on lines 25..30
sample/db/samples/variants.rb on lines 31..36
sample/db/samples/variants.rb on lines 37..42
sample/db/samples/variants.rb on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  {
    product: girly_coat,
    options: [name: Comable::Sample.t(:size), value: 'S'] + [name: Comable::Sample.t(:color), value: Comable::Sample.t(:navy)],
    stocks_attributes: [default_stock_attributes],
    sku: 'GIRLY-COAT-SN'
Severity: Major
Found in sample/db/samples/variants.rb and 5 other locations - About 25 mins to fix
sample/db/samples/variants.rb on lines 13..18
sample/db/samples/variants.rb on lines 19..24
sample/db/samples/variants.rb on lines 25..30
sample/db/samples/variants.rb on lines 31..36
sample/db/samples/variants.rb on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  {
    product: girly_coat,
    options: [name: Comable::Sample.t(:size), value: 'S'] + [name: Comable::Sample.t(:color), value: Comable::Sample.t(:beige)],
    stocks_attributes: [default_stock_attributes],
    sku: 'GIRLY-COAT-SB'
Severity: Major
Found in sample/db/samples/variants.rb and 5 other locations - About 25 mins to fix
sample/db/samples/variants.rb on lines 13..18
sample/db/samples/variants.rb on lines 19..24
sample/db/samples/variants.rb on lines 31..36
sample/db/samples/variants.rb on lines 37..42
sample/db/samples/variants.rb on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  {
    product: suede_dress,
    options: [name: Comable::Sample.t(:size), value: 'S'] + [name: Comable::Sample.t(:color), value: Comable::Sample.t(:navy)],
    stocks_attributes: [default_stock_attributes],
    sku: 'SUEDE-DRESS-SN'
Severity: Major
Found in sample/db/samples/variants.rb and 5 other locations - About 25 mins to fix
sample/db/samples/variants.rb on lines 19..24
sample/db/samples/variants.rb on lines 25..30
sample/db/samples/variants.rb on lines 31..36
sample/db/samples/variants.rb on lines 37..42
sample/db/samples/variants.rb on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

  {
    product: girly_coat,
    options: [name: Comable::Sample.t(:size), value: 'M'] + [name: Comable::Sample.t(:color), value: Comable::Sample.t(:beige)],
    stocks_attributes: [default_stock_attributes],
    sku: 'GIRLY-COAT-MB'
Severity: Major
Found in sample/db/samples/variants.rb and 5 other locations - About 25 mins to fix
sample/db/samples/variants.rb on lines 13..18
sample/db/samples/variants.rb on lines 19..24
sample/db/samples/variants.rb on lines 25..30
sample/db/samples/variants.rb on lines 37..42
sample/db/samples/variants.rb on lines 43..48

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @product.update_attributes(product_params)
          redirect_to comable.admin_product_path(@product), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/products_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/trackers_controller.rb on lines 31..37
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def update
      if current_comable_user.reset_cart_item(@cart_item, cart_item_options)
        redirect_to comable.cart_path, notice: Comable.t('carts.updated')
      else
        flash.now[:alert] = Comable.t('carts.invalid')
Severity: Minor
Found in frontend/app/controllers/comable/carts_controller.rb and 1 other location - About 15 mins to fix
frontend/app/controllers/comable/carts_controller.rb on lines 7..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @shipment_method.update_attributes(shipment_method_params)
          redirect_to comable.admin_shipment_method_path(@shipment_method), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/trackers_controller.rb on lines 31..37
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @order.update_attributes(order_params)
          redirect_to comable.admin_order_path(@order), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/orders_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/trackers_controller.rb on lines 31..37
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @stock.update_attributes(stock_params)
          redirect_to comable.admin_stock_path(@stock), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/stocks_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/trackers_controller.rb on lines 31..37
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @tracker.update_attributes(tracker_params)
          redirect_to comable.admin_tracker_path(@tracker), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/trackers_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def add
      if current_comable_user.add_cart_item(@cart_item, cart_item_options)
        redirect_to comable.cart_path, notice: Comable.t('carts.added')
      else
        flash.now[:alert] = Comable.t('carts.invalid')
Severity: Minor
Found in frontend/app/controllers/comable/carts_controller.rb and 1 other location - About 15 mins to fix
frontend/app/controllers/comable/carts_controller.rb on lines 16..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @theme.update_attributes(theme_params)
          redirect_to comable.admin_theme_path(@theme), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/themes_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/trackers_controller.rb on lines 31..37
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language