appnexus/sicksync

View on GitHub

Showing 21 of 21 total issues

Function add has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const add = (config) => {
  const questions = {
    project: {
      description: 'What would you like to name this project?',
      required: true,
Severity: Major
Found in src/project-helper.js - About 3 hrs to fix

    File doctor.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import os from 'os';
    import { spawnSync } from 'child_process';
    import _ from 'lodash';
    import chalk from 'chalk';
    import fs from 'fs-extra';
    Severity: Minor
    Found in src/doctor.js - About 2 hrs to fix

      Function startProject has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function startProject(config, projectConf) {
        const FSHelper = uniqInstance(constants.FS_TOKEN, FSConstructor);
        const WebSocketClient = uniqInstance(constants.WS_TOKEN, WSConstructor);
      
        const localLog = generateLog(projectConf.project, hostname);
      Severity: Major
      Found in src/local/index.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          addDir(message) {
            fs.mkdirs(untildify(message.destinationpath), (err) => {
              if (err) return this.emit(fsEvents.ADD_DIR_ERROR, err);
        
              this.emit(fsEvents.ADD_DIR, message.destinationpath);
        Severity: Major
        Found in src/remote/fs-helper.js and 1 other location - About 2 hrs to fix
        src/remote/fs-helper.js on lines 30..36

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          removePath(message) {
            fs.remove(untildify(message.destinationpath), (err) => {
              if (err) return this.emit(fsEvents.DELETE_ERROR, err);
        
              this.emit(fsEvents.DELETE, message.destinationpath);
        Severity: Major
        Found in src/remote/fs-helper.js and 1 other location - About 2 hrs to fix
        src/remote/fs-helper.js on lines 22..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function startRemote has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function startRemote(opts) {
          if (!_.isNumber(opts.port)) return console.info(text.REMOTE_MISSING_PORT);
          if (!_.isString(opts.secret)) return console.info(text.REMOTE_MISSING_SECRET);
        
          const log = _.partial(console.info.bind(console), opts.secret);
        Severity: Minor
        Found in src/remote/index.js - About 1 hr to fix

          Function checkAll has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function checkAll(config) {
            console.info(chalk.yellow('* Checking if config is present...'));
          
            hasConfig()
              .then(() => {
          Severity: Minor
          Found in src/doctor.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (_.isUndefined(project[key])) {
                    console.info(chalk.red(`Project is missing:`, key));
                    console.info('Please make sure your project has a', key, 'property');
                    return false;
                  }
            Severity: Major
            Found in src/doctor.js and 1 other location - About 1 hr to fix
            src/doctor.js on lines 185..189

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (_.isUndefined(config[key])) {
                    console.info(chalk.red(`Config is missing:`, key));
                    console.info('Please make sure your config has a', key, 'property');
                    return false;
                  }
            Severity: Major
            Found in src/doctor.js and 1 other location - About 1 hr to fix
            src/doctor.js on lines 214..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function bigSync has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export function bigSync(project) {
              const log = generateLog(project.project, os.hostname());
            
              function consoleLogFromBuffer(buffer) {
                log(buffer.toString());
            Severity: Minor
            Found in src/big-sync.js - About 1 hr to fix

              Function hasCygwinOnWindows has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export function hasCygwinOnWindows(project) {
                return new Promise((resolve, reject) => {
                  let erroredCommands = [];
                  function test({command, args = [], expectError}) {
                    const output = spawnSync(command, args, {encoding: 'utf8'});
              Severity: Minor
              Found in src/doctor.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function sicksyncAddProjectCommand(program, config) {
                  program
                    .command('add-project')
                    .alias('add')
                    .description('Adds a new project to sicksync.')
                Severity: Major
                Found in src/commands/add-project.js and 1 other location - About 1 hr to fix
                src/commands/remove-project.js on lines 4..10

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function sicksyncRemoveProjectCommand(program, config) {
                  program
                    .command('remove-project <projects...>')
                    .alias('rm')
                    .description('Removes a project from sicksync.')
                Severity: Major
                Found in src/commands/remove-project.js and 1 other location - About 1 hr to fix
                src/commands/add-project.js on lines 4..10

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 55.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                  hasConfig()
                    .then(() => {
                      console.info(chalk.yellow('\n* Checking config file...'));
                      return configHasRightShape(config);
                    })
                Severity: Major
                Found in src/doctor.js and 3 other locations - About 45 mins to fix
                src/doctor.js on lines 273..295
                src/doctor.js on lines 273..300
                src/doctor.js on lines 273..305

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function sicksyncDoctor(program, config) {
                  program
                    .command('doctor')
                    .description('Runs through a gammut of checks to make sure sicksync is working properly')
                    .action(partial(ary(checkAll, 1), config));
                Severity: Minor
                Found in src/commands/doctor.js and 1 other location - About 35 mins to fix
                src/commands/info.js on lines 4..9

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (_.includes(message, 'ERR!')) {
                      console.info(project.hostname, text.UPDATE_FAIL);
                
                      return ssh.kill('SIGINT');
                    }
                Severity: Minor
                Found in src/update.js and 1 other location - About 35 mins to fix
                src/update.js on lines 33..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (_.includes(message, 'sicksync@')) {
                      console.info(project.hostname, text.UPDATE_SUCCESS);
                
                      return ssh.kill('SIGINT');
                    }
                Severity: Minor
                Found in src/update.js and 1 other location - About 35 mins to fix
                src/update.js on lines 39..43

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                function sicksyncInfoCommand(program, config) {
                  program
                    .command('info [project...]')
                    .description('Shows the information for the supplied project(s)')
                    .action(partial(ary(info, 2), config));
                Severity: Minor
                Found in src/commands/info.js and 1 other location - About 35 mins to fix
                src/commands/doctor.js on lines 5..10

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this._devbox.on(remoteEvents.MESSAGE, _.partial(this.emit.bind(this), wsEvents.REMOTE_MESSAGE));
                Severity: Minor
                Found in src/local/ws-client.js and 1 other location - About 30 mins to fix
                src/local/ws-client.js on lines 63..63

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    this._devbox.on(remoteEvents.NOT_FOUND, _.partial(this.emit.bind(this), wsEvents.REMOTE_NOT_FOUND));
                Severity: Minor
                Found in src/local/ws-client.js and 1 other location - About 30 mins to fix
                src/local/ws-client.js on lines 62..62

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language