Showing 84 of 84 total issues
File diagnose.rb
has 484 lines of code (exceeds 250 allowed). Consider refactoring. Open
require "rbconfig"
require "etc"
require "appsignal/cli/diagnose/utils"
require "appsignal/cli/diagnose/paths"
Class Transaction
has 42 methods (exceeds 20 allowed). Consider refactoring. Open
class Transaction
HTTP_REQUEST = "http_request".freeze
BACKGROUND_JOB = "background_job".freeze
ACTION_CABLE = "action_cable".freeze
FRONTEND = "frontend".freeze
File jruby.rb
has 391 lines of code (exceeds 250 allowed). Consider refactoring. Open
require "ffi"
module Appsignal
class Extension
# JRuby extension wrapper
Class Diagnose
has 37 methods (exceeds 20 allowed). Consider refactoring. Open
class Diagnose
extend CLI::Helpers
DIAGNOSE_ENDPOINT = "https://appsignal.com/diag".freeze
Method install
has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open
def install
library_type = "static"
report["language"]["implementation"] = "ruby"
report["build"]["library_type"] = library_type
return unless check_architecture
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File transaction.rb
has 316 lines of code (exceeds 250 allowed). Consider refactoring. Open
require "json"
module Appsignal
class Transaction
HTTP_REQUEST = "http_request".freeze
Method start
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def start
unless extension_loaded?
logger.info("Not starting appsignal, extension is not loaded")
return
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File config.rb
has 283 lines of code (exceeds 250 allowed). Consider refactoring. Open
require "erb"
require "yaml"
require "uri"
require "socket"
require "tmpdir"
File install.rb
has 268 lines of code (exceeds 250 allowed). Consider refactoring. Open
require "erb"
require "ostruct"
require "io/console"
require "appsignal/demo"
Method format
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
def format(payload)
return unless payload[:ops]
return if payload[:ops].empty?
op = payload[:ops].first
Similar blocks of code found in 2 locations. Consider refactoring. Open
ActionCable::Channel::Base.set_callback :subscribe, :around, :prepend => true do |channel, inner|
# The request is only the original websocket request
env = channel.connection.env
request = ActionDispatch::Request.new(env)
env[Appsignal::Hooks::ActionCableHook::REQUEST_ID] ||=
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 85.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
ActionCable::Channel::Base.set_callback :unsubscribe, :around, :prepend => true do |channel, inner|
# The request is only the original websocket request
env = channel.connection.env
request = ActionDispatch::Request.new(env)
env[Appsignal::Hooks::ActionCableHook::REQUEST_ID] ||=
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 85.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method run
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
def run(push_api_key, options) # rubocop:disable Metrics/AbcSize
self.coloring = options.delete(:color) { true }
$stdout.sync = true
puts
Method agent_diagnostic_test_definition
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
def agent_diagnostic_test_definition
{
"extension" => {
:label => "Extension tests",
:tests => {
File sidekiq.rb
has 251 lines of code (exceeds 250 allowed). Consider refactoring. Open
require "yaml"
module Appsignal
class Hooks
class SidekiqHook < Appsignal::Hooks::Hook
Method install_callbacks
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
def install_callbacks
ActionCable::Channel::Base.set_callback :subscribe, :around, :prepend => true do |channel, inner|
# The request is only the original websocket request
env = channel.connection.env
request = ActionDispatch::Request.new(env)
Method command_option_parser
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
def command_option_parser
{
"demo" => OptionParser.new do |o|
o.banner = "Usage: appsignal demo [options]"
Method tasks
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.tasks(config)
config.load do # rubocop:disable Metrics/BlockLength
after "deploy", "appsignal:deploy"
after "deploy:migrations", "appsignal:deploy"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method configure
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
def configure(config, environments, name_overwritten)
install_for_capistrano
ENV["APPSIGNAL_APP_ENV"] = "development"
Method tasks
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.tasks(config)
config.load do # rubocop:disable Metrics/BlockLength
after "deploy", "appsignal:deploy"
after "deploy:migrations", "appsignal:deploy"