Sign upLogin

arbox/wlapi

View on GitHub
Star

Showing 8 of 8 total issues

Method check_params has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    def check_params(*args)
      m = caller(1).first.match(/^.+`(.*)'$/)[1]
      num_of_args = self.method(m.to_sym).arity
      messages = []
Severity: Minor
Found in lib/wlapi/api.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class API has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class API
    include REXML

    # SOAP Services Endpoint.
    ENDPOINT = 'http://wortschatz.uni-leipzig.de/axis/services'
Severity: Minor
Found in lib/wlapi/api.rb - About 2 hrs to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        def left_collocation_finder(word, pos, limit = 10)
      check_params(word, pos, limit)

      arg1 = ['Wort', word]
      arg2 = ['Wortart', pos]
    Severity: Major
    Found in lib/wlapi/api.rb and 5 other locations - About 20 mins to fix
    lib/wlapi/api.rb on lines 281..289
    lib/wlapi/api.rb on lines 312..320
    lib/wlapi/api.rb on lines 327..335
    lib/wlapi/api.rb on lines 345..353
    lib/wlapi/api.rb on lines 369..377

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        def cooccurrences(word, sign, limit = 10)
      check_params(word, sign, limit)

      arg1 = ['Wort', word]
      arg2 = ['Mindestsignifikanz', sign]
    Severity: Major
    Found in lib/wlapi/api.rb and 5 other locations - About 20 mins to fix
    lib/wlapi/api.rb on lines 281..289
    lib/wlapi/api.rb on lines 300..308
    lib/wlapi/api.rb on lines 327..335
    lib/wlapi/api.rb on lines 345..353
    lib/wlapi/api.rb on lines 369..377

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        def cooccurrences_all(word, sign, limit = 10)
      check_params(word, sign, limit)

      arg1 = ['Wort', word]
      arg2 = ['Mindestsignifikanz', sign]
    Severity: Major
    Found in lib/wlapi/api.rb and 5 other locations - About 20 mins to fix
    lib/wlapi/api.rb on lines 281..289
    lib/wlapi/api.rb on lines 300..308
    lib/wlapi/api.rb on lines 312..320
    lib/wlapi/api.rb on lines 345..353
    lib/wlapi/api.rb on lines 369..377

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        def crossword(word, word_length, limit = 10)
      check_params(word, word_length, limit)

      arg1 = ['Wort', word ]
      arg2 = ['Wortlaenge', word_length]
    Severity: Major
    Found in lib/wlapi/api.rb and 5 other locations - About 20 mins to fix
    lib/wlapi/api.rb on lines 281..289
    lib/wlapi/api.rb on lines 300..308
    lib/wlapi/api.rb on lines 312..320
    lib/wlapi/api.rb on lines 327..335
    lib/wlapi/api.rb on lines 345..353

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        def intersection(word1, word2, limit = 10)
      check_params(word1, word2, limit)

      arg1 = ['Wort 1', word1]
      arg2 = ['Wort 2', word2]
    Severity: Major
    Found in lib/wlapi/api.rb and 5 other locations - About 20 mins to fix
    lib/wlapi/api.rb on lines 281..289
    lib/wlapi/api.rb on lines 300..308
    lib/wlapi/api.rb on lines 312..320
    lib/wlapi/api.rb on lines 327..335
    lib/wlapi/api.rb on lines 369..377

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

        def right_collocation_finder(word, pos, limit = 10)
      check_params(word, pos, limit)

      arg1 = ['Wort', word]
      arg2 = ['Wortart', pos]
    Severity: Major
    Found in lib/wlapi/api.rb and 5 other locations - About 20 mins to fix
    lib/wlapi/api.rb on lines 300..308
    lib/wlapi/api.rb on lines 312..320
    lib/wlapi/api.rb on lines 327..335
    lib/wlapi/api.rb on lines 345..353
    lib/wlapi/api.rb on lines 369..377

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language