Sign upLogin

aristath/kirki

View on GitHub
Star
packages/kirki-framework/control-repeater/src/Control/Repeater.php

Summary

Maintainability
D
2 days
Test Coverage

Method repeater_js_template has 165 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function repeater_js_template() {
        ?>

        <script type="text/html" class="customize-control-repeater-content">
            <# var field; var index = data.index; #>
Severity: Major
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php - About 6 hrs to fix

Function __construct has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct( $manager, $id, $args = [] ) {

        parent::__construct( $manager, $id, $args );

        // Set up defaults for row labels.
Severity: Minor
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Repeater.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Customizer Control: repeater.
 *
 * @package   kirki-framework/control-repeater
Severity: Minor
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php - About 3 hrs to fix

Method __construct has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct( $manager, $id, $args = [] ) {

        parent::__construct( $manager, $id, $args );

        // Set up defaults for row labels.
Severity: Major
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php - About 2 hrs to fix

Function row_label has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function row_label( $args ) {

        // Validating args for row labels.
        if ( isset( $args['row_label'] ) && is_array( $args['row_label'] ) && ! empty( $args['row_label'] ) ) {
Severity: Minor
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                                if ( $url ) {

                                    // 'id' is needed for form hidden value, URL is needed to display the image.
                                    $value = [
                                        'id'       => $attachment_id,
Severity: Major
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function enqueue() {

        parent::enqueue();

        // Enqueue the script.
Severity: Major
Found in packages/kirki-framework/control-repeater/src/Control/Repeater.php and 1 other location - About 1 hr to fix
packages/kirki-framework/control-sortable/src/Control/Sortable.php on lines 47..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status