artirix/artirix_data_models

View on GitHub

Showing 35 of 35 total issues

File model.rb has 421 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ArtirixDataModels
  module Model
    extend ActiveSupport::Concern

    included do
Severity: Minor
Found in lib/artirix_data_models/model.rb - About 6 hrs to fix

    File data_gateway.rb has 367 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ArtirixDataModels::DataGateway
      attr_reader :connection, :post_as_json
    
      def initialize(connection: nil,
                     post_as_json: true,
    Severity: Minor
    Found in lib/artirix_data_models/gateways/data_gateway.rb - About 4 hrs to fix

      Method connect has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
      Open

        def connect(method,
                    path:,
                    body: nil,
                    json_body: true,
                    timeout: nil,
      Severity: Minor
      Found in lib/artirix_data_models/gateways/data_gateway.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class ADMRegistry has 29 methods (exceeds 20 allowed). Consider refactoring.
      Open

      class ArtirixDataModels::ADMRegistry
        @instance_mutex = Mutex.new
      
        def self.instance_mutex
          ArtirixDataModels::ADMRegistry.instance_variable_get :@instance_mutex
      Severity: Minor
      Found in lib/artirix_data_models/adm_registry.rb - About 3 hrs to fix

        Class BasicModelDAO has 26 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class ArtirixDataModels::BasicModelDAO
          include ArtirixDataModels::DAOConcerns::WithResponseAdaptors
          include ArtirixDataModels::WithADMRegistry
        
          attr_reader :model_name, :model_class, :paths_factory, :fake_mode_factory, :gateway_factory
        Severity: Minor
        Found in lib/artirix_data_models/daos/basic_model_dao.rb - About 3 hrs to fix

          Method build has 69 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def build
                  model = self.model
                  null  = Naught.build do |config|
                    config.impersonate model
                    config.predicates_return false
          Severity: Major
          Found in lib/artirix_data_models/active_null.rb - About 2 hrs to fix

            File basic_model_dao.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            class ArtirixDataModels::BasicModelDAO
              include ArtirixDataModels::DAOConcerns::WithResponseAdaptors
              include ArtirixDataModels::WithADMRegistry
            
              attr_reader :model_name, :model_class, :paths_factory, :fake_mode_factory, :gateway_factory
            Severity: Minor
            Found in lib/artirix_data_models/daos/basic_model_dao.rb - About 2 hrs to fix

              Class DataGateway has 24 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class ArtirixDataModels::DataGateway
                attr_reader :connection, :post_as_json
              
                def initialize(connection: nil,
                               post_as_json: true,
              Severity: Minor
              Found in lib/artirix_data_models/gateways/data_gateway.rb - About 2 hrs to fix

                Class EsCollection has 24 methods (exceeds 20 allowed). Consider refactoring.
                Open

                  class EsCollection
                
                    DEFAULT_SIZE                = 10
                    CACHE_KEY_SECTION_SEPARATOR = '/'.freeze
                    CACHE_KEY_RESULT_SEPARATOR  = '\\'.freeze
                Severity: Minor
                Found in lib/artirix_data_models/es_collection.rb - About 2 hrs to fix

                  Method connection has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def connection(config: {},
                                       url: nil,
                                       login: nil,
                                       password: nil,
                                       bearer_token: nil,
                  Severity: Minor
                  Found in lib/artirix_data_models/gateways/data_gateway.rb - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                    def perform_put(path,
                                    authorization_bearer: nil,
                                    authorization_token_hash: nil,
                                    body: nil,
                                    cache_adaptor: nil,
                  Severity: Major
                  Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                    def perform_post(path,
                                     authorization_bearer: nil,
                                     authorization_token_hash: nil,
                                     body: nil,
                                     cache_adaptor: nil,
                  Severity: Major
                  Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                    def perform_get(path,
                                    authorization_bearer: nil,
                                    authorization_token_hash: nil,
                                    body: nil,
                                    cache_adaptor: nil,
                  Severity: Major
                  Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                    def perform_delete(path,
                                       authorization_bearer: nil,
                                       authorization_token_hash: nil,
                                       body: nil,
                                       cache_adaptor: nil,
                  Severity: Major
                  Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 275..305

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                    def perform_patch(path,
                                      authorization_bearer: nil,
                                      authorization_token_hash: nil,
                                      body: nil,
                                      cache_adaptor: nil,
                  Severity: Major
                  Found in lib/artirix_data_models/daos/basic_model_dao.rb and 4 other locations - About 1 hr to fix
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 175..206
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 209..240
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 242..273
                  lib/artirix_data_models/daos/basic_model_dao.rb on lines 307..337

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method call has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def call(method,
                             path,
                             authorization_bearer: nil,
                             authorization_token_hash: nil,
                             body: nil,
                  Severity: Minor
                  Found in lib/artirix_data_models/gateways/data_gateway.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method call has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def call(method,
                             path,
                             authorization_bearer: nil,
                             authorization_token_hash: nil,
                             body: nil,
                  Severity: Minor
                  Found in lib/artirix_data_models/gateways/data_gateway.rb - About 1 hr to fix

                    Method mock_gateway_response has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def mock_gateway_response(response:,
                                              method:,
                                              path:,
                                              body: nil,
                                              json_body: true,
                    Severity: Minor
                    Found in lib/artirix_data_models/spec_support/gateway_mock.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method locate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def self.locate(comparator, object, result = [])
                          if object.is_a?(::Enumerable)
                            if object.any? { |value| match_comparator?(value, comparator, object) }
                              result.push object
                            else # DO NOT LOOK DEEPER ONCE FOUND IF THE VALUE FOUND IS A HASH (this will prevent us from properly recognising nested aggregations)!
                    Severity: Minor
                    Found in lib/artirix_data_models/raw_aggregation_data_normaliser.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method connect has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def connect(method,
                                  path:,
                                  body: nil,
                                  json_body: true,
                                  timeout: nil,
                    Severity: Minor
                    Found in lib/artirix_data_models/gateways/data_gateway.rb - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language