arttor/helmify

View on GitHub

Showing 51 of 51 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package rbac

import (
    "fmt"
    "io"
Severity: Major
Found in pkg/processor/rbac/clusterrolebinding.go and 1 other location - About 1 day to fix
pkg/processor/rbac/rolebinding.go on lines 1..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 733.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package rbac

import (
    "fmt"
    "io"
Severity: Major
Found in pkg/processor/rbac/rolebinding.go and 1 other location - About 1 day to fix
pkg/processor/rbac/clusterrolebinding.go on lines 1..104

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 733.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package webhook

import (
    "bytes"
    "fmt"
Severity: Major
Found in pkg/processor/webhook/validating.go and 1 other location - About 1 day to fix
pkg/processor/webhook/mutating.go on lines 1..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 701.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

package webhook

import (
    "bytes"
    "fmt"
Severity: Major
Found in pkg/processor/webhook/mutating.go and 1 other location - About 1 day to fix
pkg/processor/webhook/validating.go on lines 1..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 701.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Walk has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

func Walk(paths []string, recursively bool, walkFunc func(filename string, r io.Reader)) {

    for _, path := range paths {
        info, err := os.Stat(path)
        if err != nil {
Severity: Minor
Found in pkg/file/reader.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method statefulset.Process has 89 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (d statefulset) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
    if obj.GroupVersionKind() != statefulsetGVC {
        return false, nil, nil
    }
    ss := appsv1.StatefulSet{}
Severity: Major
Found in pkg/processor/statefulset/statefulset.go - About 2 hrs to fix

    Method cron.Process has 84 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (p cron) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
        if obj.GroupVersionKind() != cronGVC {
            return false, nil, nil
        }
        meta, err := processor.ProcessObjMeta(appMeta, obj)
    Severity: Major
    Found in pkg/processor/job/cron.go - About 2 hrs to fix

      Method job.Process has 84 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (p job) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
          if obj.GroupVersionKind() != jobGVC {
              return false, nil, nil
          }
          meta, err := processor.ProcessObjMeta(appMeta, obj)
      Severity: Major
      Found in pkg/processor/job/job.go - About 2 hrs to fix

        Method deployment.Process has 83 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (d deployment) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
            if obj.GroupVersionKind() != deploymentGVC {
                return false, nil, nil
            }
            depl := appsv1.Deployment{}
        Severity: Major
        Found in pkg/processor/deployment/deployment.go - About 2 hrs to fix

          Method crd.Process has 75 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (c crd) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
              if obj.GroupVersionKind() != crdGVC {
                  return false, nil, nil
              }
              name, ok, err := unstructured.NestedString(obj.Object, "spec", "names", "singular")
          Severity: Minor
          Found in pkg/processor/crd/crd.go - About 2 hrs to fix

            Method secret.Process has 73 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            func (d secret) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                if obj.GroupVersionKind() != configMapGVC {
                    return false, nil, nil
                }
                sec := corev1.Secret{}
            Severity: Minor
            Found in pkg/processor/secret/secret.go - About 1 hr to fix

              Function Walk has 71 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

              func Walk(paths []string, recursively bool, walkFunc func(filename string, r io.Reader)) {
              
                  for _, path := range paths {
                      info, err := os.Stat(path)
                      if err != nil {
              Severity: Minor
              Found in pkg/file/reader.go - About 1 hr to fix

                Method daemonset.Process has 71 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                func (d daemonset) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                    if obj.GroupVersionKind() != daemonsetGVC {
                        return false, nil, nil
                    }
                    dae := appsv1.DaemonSet{}
                Severity: Minor
                Found in pkg/processor/daemonset/daemonset.go - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func processReplicas(name string, deployment *appsv1.Deployment, values *helmify.Values) (string, error) {
                      if deployment.Spec.Replicas == nil {
                          return "", nil
                      }
                      replicasTpl, err := values.Add(int64(*deployment.Spec.Replicas), name, "replicas")
                  Severity: Major
                  Found in pkg/processor/deployment/deployment.go and 1 other location - About 1 hr to fix
                  pkg/processor/deployment/deployment.go on lines 172..186

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 175.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method statefulset.Process has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
                  Open

                  func (d statefulset) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                      if obj.GroupVersionKind() != statefulsetGVC {
                          return false, nil, nil
                      }
                      ss := appsv1.StatefulSet{}
                  Severity: Minor
                  Found in pkg/processor/statefulset/statefulset.go - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  func processRevisionHistoryLimit(name string, deployment *appsv1.Deployment, values *helmify.Values) (string, error) {
                      if deployment.Spec.RevisionHistoryLimit == nil {
                          return "", nil
                      }
                      revisionHistoryLimitTpl, err := values.Add(int64(*deployment.Spec.RevisionHistoryLimit), name, "revisionHistoryLimit")
                  Severity: Major
                  Found in pkg/processor/deployment/deployment.go and 1 other location - About 1 hr to fix
                  pkg/processor/deployment/deployment.go on lines 156..170

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 175.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method cron.Process has 16 return statements (exceeds 4 allowed).
                  Open

                  func (p cron) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                      if obj.GroupVersionKind() != cronGVC {
                          return false, nil, nil
                      }
                      meta, err := processor.ProcessObjMeta(appMeta, obj)
                  Severity: Major
                  Found in pkg/processor/job/cron.go - About 1 hr to fix

                    Method job.Process has 16 return statements (exceeds 4 allowed).
                    Open

                    func (p job) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                        if obj.GroupVersionKind() != jobGVC {
                            return false, nil, nil
                        }
                        meta, err := processor.ProcessObjMeta(appMeta, obj)
                    Severity: Major
                    Found in pkg/processor/job/job.go - About 1 hr to fix

                      Method pvc.Process has 61 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      func (p pvc) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                          if obj.GroupVersionKind() != pvcGVC {
                              return false, nil, nil
                          }
                          meta, err := processor.ProcessObjMeta(appMeta, obj)
                      Severity: Minor
                      Found in pkg/processor/storage/pvc.go - About 1 hr to fix

                        Method cron.Process has a Cognitive Complexity of 27 (exceeds 20 allowed). Consider refactoring.
                        Open

                        func (p cron) Process(appMeta helmify.AppMetadata, obj *unstructured.Unstructured) (bool, helmify.Template, error) {
                            if obj.GroupVersionKind() != cronGVC {
                                return false, nil, nil
                            }
                            meta, err := processor.ProcessObjMeta(appMeta, obj)
                        Severity: Minor
                        Found in pkg/processor/job/cron.go - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language