Sign upLogin

asteris-llc/converge

View on GitHub
Star
keystore/keystore.go

Summary

Maintainability
A
2 hrs
Test Coverage

Function loadKeyring has a Cognitive Complexity of 24 (exceeds 20 allowed). Consider refactoring.
Open

func loadKeyring(ks *Keystore) (openpgp.KeyRing, error) {
    var keyring openpgp.EntityList
    trustedKeys := make(map[string]*openpgp.Entity)

    for _, p := range []string{ks.SystemPath, ks.UserPath, ks.LocalPath} {
Severity: Minor
Found in keystore/keystore.go - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function loadKeyring has 6 return statements (exceeds 4 allowed).
Open

func loadKeyring(ks *Keystore) (openpgp.KeyRing, error) {
    var keyring openpgp.EntityList
    trustedKeys := make(map[string]*openpgp.Entity)

    for _, p := range []string{ks.SystemPath, ks.UserPath, ks.LocalPath} {
Severity: Major
Found in keystore/keystore.go - About 40 mins to fix

    Method Keystore.StoreTrustedKey has 5 return statements (exceeds 4 allowed).
    Open

    func (ks *Keystore) StoreTrustedKey(pubkeyBytes []byte) (string, error) {
    if err := os.MkdirAll(ks.UserPath, 0755); err != nil {
        return "", err
    }
    Severity: Major
    Found in keystore/keystore.go - About 35 mins to fix

      Method Keystore.CheckSignature has 5 return statements (exceeds 4 allowed).
      Open

      func (ks *Keystore) CheckSignature(signed, signature io.Reader) error {
    if ks.keyring == nil {
        keyring, err := loadKeyring(ks)
        if err != nil {
            return errors.Wrap(err, "error loading keyring")
      Severity: Major
      Found in keystore/keystore.go - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status