asteris-llc/converge

View on GitHub
load/nodes.go

Summary

Maintainability
B
5 hrs
Test Coverage

Function Nodes has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

func Nodes(ctx context.Context, root string, verify bool) (*graph.Graph, error) {
    logger := logging.GetLogger(ctx).WithField("function", "Nodes")

    toLoad := []*source{{"root", root, root}}

Severity: Minor
Found in load/nodes.go - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Nodes has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Nodes(ctx context.Context, root string, verify bool) (*graph.Graph, error) {
    logger := logging.GetLogger(ctx).WithField("function", "Nodes")

    toLoad := []*source{{"root", root, root}}

Severity: Minor
Found in load/nodes.go - About 1 hr to fix

    Function expandSwitchMacro has 55 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func expandSwitchMacro(data []byte, current *source, n *parse.Node, g *graph.Graph) (*graph.Graph, error) {
        if !control.IsSwitchNode(n) {
            return g, nil
        }
        switchObj, err := control.NewSwitch(n, data)
    Severity: Minor
    Found in load/nodes.go - About 1 hr to fix

      Function Nodes has 8 return statements (exceeds 4 allowed).
      Open

      func Nodes(ctx context.Context, root string, verify bool) (*graph.Graph, error) {
          logger := logging.GetLogger(ctx).WithField("function", "Nodes")
      
          toLoad := []*source{{"root", root, root}}
      
      
      Severity: Major
      Found in load/nodes.go - About 50 mins to fix

        Function expandSwitchMacro has 6 return statements (exceeds 4 allowed).
        Open

        func expandSwitchMacro(data []byte, current *source, n *parse.Node, g *graph.Graph) (*graph.Graph, error) {
            if !control.IsSwitchNode(n) {
                return g, nil
            }
            switchObj, err := control.NewSwitch(n, data)
        Severity: Major
        Found in load/nodes.go - About 40 mins to fix

          There are no issues that match your filters.

          Category
          Status