Sign upLogin

asteris-llc/converge

View on GitHub
Star
resource/docker/docker.go

Summary

Maintainability
A
2 hrs
Test Coverage

Method Client.CreateContainer has 5 return statements (exceeds 4 allowed).
Open

func (c *Client) CreateContainer(opts dc.CreateContainerOptions) (*dc.Container, error) {
    name := opts.Name

    container, err := c.FindContainer(name)
    if err != nil {
Severity: Major
Found in resource/docker/docker.go - About 35 mins to fix

    TODO found
    Open

        // TODO: can I just call inspect with the repoTag?
    Severity: Minor
    Found in resource/docker/docker.go by fixme

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (c *Client) CreateNetwork(opts dc.CreateNetworkOptions) (*dc.Network, error) {
    log.WithFields(log.Fields{
        "module":   "docker",
        "function": "CreateNetwork",
    }).Debugf("creating network %s: %+v", opts.Name, opts)
    Severity: Major
    Found in resource/docker/docker.go and 1 other location - About 1 hr to fix
    resource/docker/docker.go on lines 236..247

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 136.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (c *Client) CreateVolume(opts dc.CreateVolumeOptions) (*dc.Volume, error) {
    log.WithFields(log.Fields{
        "module":   "docker",
        "function": "CreateVolume",
    }).Debugf("creating volume %s: %+v", opts.Name, opts)
    Severity: Major
    Found in resource/docker/docker.go and 1 other location - About 1 hr to fix
    resource/docker/docker.go on lines 312..323

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 136.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    // Copyright © 2016 Asteris, LLC
    Severity: Minor
    Found in resource/docker/docker.go by gofmt

    There are no issues that match your filters.

    Category
    Status