Sign upLogin

asteris-llc/converge

View on GitHub
Star
resource/file/fetch/fetch.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method Fetch.applyWithContext has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (f *Fetch) applyWithContext(context.Context) (resource.TaskStatus, error) {
    var (
        hsh      hash.Hash
        err      error
        status   = resource.NewStatus()
Severity: Minor
Found in resource/file/fetch/fetch.go - About 1 hr to fix

    Method Fetch.DiffFile has 7 return statements (exceeds 4 allowed).
    Open

    func (f *Fetch) DiffFile(status *resource.Status, hsh hash.Hash) (*resource.Status, error) {
    // the destination should be a file if fetching without an unarchive
    // if unarchiving, the destination should be a directory
    stat, err := os.Stat(f.Destination)
    if err == nil {
    Severity: Major
    Found in resource/file/fetch/fetch.go - About 45 mins to fix

      Method Fetch.applyWithContext has 7 return statements (exceeds 4 allowed).
      Open

      func (f *Fetch) applyWithContext(context.Context) (resource.TaskStatus, error) {
    var (
        hsh      hash.Hash
        err      error
        status   = resource.NewStatus()
      Severity: Major
      Found in resource/file/fetch/fetch.go - About 45 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (f *Fetch) Check(ctx context.Context, r resource.Renderer) (resource.TaskStatus, error) {
    ch := make(chan response, 1)

    go func(ctx context.Context, r resource.Renderer) {
        status, err := f.checkWithContext(ctx, r)
        Severity: Major
        Found in resource/file/fetch/fetch.go and 1 other location - About 1 hr to fix
        resource/unarchive/unarchive.go on lines 108..122

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 177.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (f *Fetch) Apply(ctx context.Context) (resource.TaskStatus, error) {
    ch := make(chan response, 1)

    go func(ctx context.Context) {
        status, err := f.applyWithContext(ctx)
        Severity: Major
        Found in resource/file/fetch/fetch.go and 1 other location - About 1 hr to fix
        resource/unarchive/unarchive.go on lines 125..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 157.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status