asteris-llc/converge

View on GitHub
resource/file/owner/owner_test.go

Summary

Maintainability
F
4 days
Test Coverage

Function TestCheck has 381 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestCheck(t *testing.T) {
    t.Parallel()

    users := []*user.User{
        fakeUser("1", "1", "user-1"),
Severity: Major
Found in resource/file/owner/owner_test.go - About 1 day to fix

    Function TestApply has 82 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestApply(t *testing.T) {
        t.Parallel()
        t.Run("single-diff", func(t *testing.T) {
            users := []*user.User{fakeUser("1", "1", "user-1"), fakeUser("2", "2", "user-2")}
            groups := []*user.Group{fakeGroup("1", "group-1"), fakeGroup("2", "group-2")}
    Severity: Major
    Found in resource/file/owner/owner_test.go - About 2 hrs to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          t.Run("when-group-change-and-user-no-change", func(t *testing.T) {
              t.Parallel()
      
              o := (&owner.Owner{
                  Destination: "foo",
      Severity: Major
      Found in resource/file/owner/owner_test.go and 3 other locations - About 4 hrs to fix
      resource/file/owner/owner_test.go on lines 152..176
      resource/file/owner/owner_test.go on lines 178..202
      resource/file/owner/owner_test.go on lines 230..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 316.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          t.Run("when-group-change-and-user-unspecified", func(t *testing.T) {
              t.Parallel()
      
              o := (&owner.Owner{
                  Destination: "foo",
      Severity: Major
      Found in resource/file/owner/owner_test.go and 3 other locations - About 4 hrs to fix
      resource/file/owner/owner_test.go on lines 152..176
      resource/file/owner/owner_test.go on lines 178..202
      resource/file/owner/owner_test.go on lines 204..228

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 316.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          t.Run("when-user-change-and-group-unspecified", func(t *testing.T) {
              t.Parallel()
      
              o := (&owner.Owner{
                  Destination: "foo",
      Severity: Major
      Found in resource/file/owner/owner_test.go and 3 other locations - About 4 hrs to fix
      resource/file/owner/owner_test.go on lines 152..176
      resource/file/owner/owner_test.go on lines 204..228
      resource/file/owner/owner_test.go on lines 230..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 316.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          t.Run("when-user-change-and-group-no-change", func(t *testing.T) {
              t.Parallel()
      
              o := (&owner.Owner{
                  Destination: "foo",
      Severity: Major
      Found in resource/file/owner/owner_test.go and 3 other locations - About 4 hrs to fix
      resource/file/owner/owner_test.go on lines 178..202
      resource/file/owner/owner_test.go on lines 204..228
      resource/file/owner/owner_test.go on lines 230..254

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 316.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          t.Run("when-user-no-change", func(t *testing.T) {
              t.Parallel()
      
              o := (&owner.Owner{
                  Destination: "foo",
      Severity: Major
      Found in resource/file/owner/owner_test.go and 1 other location - About 1 hr to fix
      resource/file/owner/owner_test.go on lines 108..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 177.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          t.Run("when-group-no-change", func(t *testing.T) {
              t.Parallel()
      
              o := (&owner.Owner{
                  Destination: "foo",
      Severity: Major
      Found in resource/file/owner/owner_test.go and 1 other location - About 1 hr to fix
      resource/file/owner/owner_test.go on lines 92..106

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 177.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status