asteris-llc/converge

View on GitHub
resource/file/owner/preparer_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function TestPreparer has 56 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestPreparer(t *testing.T) {
    users := []*user.User{fakeUser("1", "1", "user-1")}
    groups := []*user.Group{fakeGroup("1", "group-1")}
    t.Run("implements-resource", func(t *testing.T) {
        assert.Implements(t, (*resource.Resource)(nil), new(owner.Preparer))
Severity: Minor
Found in resource/file/owner/preparer_test.go - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            t.Run("when-gid", func(t *testing.T) {
                g := new(int)
                *g = 1
                p := (&owner.Preparer{GID: g}).SetOSProxy(m)
                oRes, err := p.Prepare(context.Background(), fakerenderer.New())
    Severity: Major
    Found in resource/file/owner/preparer_test.go and 1 other location - About 2 hrs to fix
    resource/file/owner/preparer_test.go on lines 49..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 211.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            t.Run("when-uid", func(t *testing.T) {
                u := new(int)
                *u = 1
                p := (&owner.Preparer{UID: u}).SetOSProxy(m)
                oRes, err := p.Prepare(context.Background(), fakerenderer.New())
    Severity: Major
    Found in resource/file/owner/preparer_test.go and 1 other location - About 2 hrs to fix
    resource/file/owner/preparer_test.go on lines 73..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 211.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            t.Run("when-username", func(t *testing.T) {
                p := (&owner.Preparer{Username: "user-1"}).SetOSProxy(m)
                oRes, err := p.Prepare(context.Background(), fakerenderer.New())
                require.NoError(t, err)
                o, ok := oRes.(*owner.Owner)
    Severity: Major
    Found in resource/file/owner/preparer_test.go and 1 other location - About 2 hrs to fix
    resource/file/owner/preparer_test.go on lines 62..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            t.Run("when-groupname", func(t *testing.T) {
                p := (&owner.Preparer{Groupname: "group-1"}).SetOSProxy(m)
                oRes, err := p.Prepare(context.Background(), fakerenderer.New())
                require.NoError(t, err)
                o, ok := oRes.(*owner.Owner)
    Severity: Major
    Found in resource/file/owner/preparer_test.go and 1 other location - About 2 hrs to fix
    resource/file/owner/preparer_test.go on lines 38..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status