asteris-llc/converge

View on GitHub
resource/group/group.go

Summary

Maintainability
F
3 days
Test Coverage

Method Group.Apply has a Cognitive Complexity of 74 (exceeds 20 allowed). Consider refactoring.
Open

func (g *Group) Apply(context.Context) (resource.TaskStatus, error) {
    var (
        groupByGid *user.Group
        gidErr     error
        newNameErr error
Severity: Minor
Found in resource/group/group.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Group.Apply has 138 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (g *Group) Apply(context.Context) (resource.TaskStatus, error) {
    var (
        groupByGid *user.Group
        gidErr     error
        newNameErr error
Severity: Major
Found in resource/group/group.go - About 4 hrs to fix

    Method Group.Check has a Cognitive Complexity of 45 (exceeds 20 allowed). Consider refactoring.
    Open

    func (g *Group) Check(context.Context, resource.Renderer) (resource.TaskStatus, error) {
        var (
            groupByGid     *user.Group
            gidErr         error
            groupByNewName *user.Group
    Severity: Minor
    Found in resource/group/group.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Group.Check has 130 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (g *Group) Check(context.Context, resource.Renderer) (resource.TaskStatus, error) {
        var (
            groupByGid     *user.Group
            gidErr         error
            groupByNewName *user.Group
    Severity: Major
    Found in resource/group/group.go - About 4 hrs to fix

      Method Group.Apply has 16 return statements (exceeds 4 allowed).
      Open

      func (g *Group) Apply(context.Context) (resource.TaskStatus, error) {
          var (
              groupByGid *user.Group
              gidErr     error
              newNameErr error
      Severity: Major
      Found in resource/group/group.go - About 1 hr to fix

        Method Group.Check has 13 return statements (exceeds 4 allowed).
        Open

        func (g *Group) Check(context.Context, resource.Renderer) (resource.TaskStatus, error) {
            var (
                groupByGid     *user.Group
                gidErr         error
                groupByNewName *user.Group
        Severity: Major
        Found in resource/group/group.go - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                              if err != nil {
                                  status.RaiseLevel(resource.StatusFatal)
                                  status.Output = append(status.Output, fmt.Sprintf("error adding group %s with gid %s", g.Name, g.GID))
                                  return status, errors.Wrap(err, "group add")
                              }
          Severity: Major
          Found in resource/group/group.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if err != nil {
                                    status.RaiseLevel(resource.StatusFatal)
                                    status.Output = append(status.Output, fmt.Sprintf("error adding group %s", g.Name))
                                    return status, errors.Wrap(err, "group add")
                                }
            Severity: Major
            Found in resource/group/group.go - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if err != nil {
                                      status.RaiseLevel(resource.StatusFatal)
                                      status.Output = append(status.Output, fmt.Sprintf("error modifying group %s with new name %s and new gid %s", g.Name, g.NewName, g.GID))
                                      return status, errors.Wrap(err, "group modify")
                                  }
              Severity: Major
              Found in resource/group/group.go - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if err != nil {
                                        status.RaiseLevel(resource.StatusFatal)
                                        status.Output = append(status.Output, fmt.Sprintf("error modifying group %s with new gid %s", g.Name, g.GID))
                                        return status, errors.Wrap(err, "group modify")
                                    }
                Severity: Major
                Found in resource/group/group.go - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if err != nil {
                                          status.RaiseLevel(resource.StatusFatal)
                                          status.Output = append(status.Output, fmt.Sprintf("error modifying group %s", g.Name))
                                          return status, errors.Wrap(err, "group modify")
                                      }
                  Severity: Major
                  Found in resource/group/group.go - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                case groupByName != nil && groupByGid != nil && groupByName.Name != groupByGid.Name || groupByName.Gid != groupByGid.Gid:
                                    status.RaiseLevel(resource.StatusCantChange)
                                    status.Output = append(status.Output, fmt.Sprintf("group delete: group %s and gid %s belong to different groups", g.Name, g.GID))
                                    return status, errors.New("cannot delete group")
                    Severity: Minor
                    Found in resource/group/group.go and 1 other location - About 40 mins to fix
                    resource/group/group.go on lines 157..160

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    case groupByName != nil && groupByGid != nil && groupByName.Name != groupByGid.Name || groupByName.Gid != groupByGid.Gid:
                                        status.RaiseLevel(resource.StatusCantChange)
                                        status.Output = append(status.Output, fmt.Sprintf("group add/modify: group %s and gid %s belong to different groups", g.Name, g.GID))
                                        return status, errors.New("cannot add or modify group")
                    Severity: Minor
                    Found in resource/group/group.go and 1 other location - About 40 mins to fix
                    resource/group/group.go on lines 211..214

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 111.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status